Skip to content

[$400] Apply latest design tweaks for roundtables #376

New issue
New issue
Closed
Closed
[$400] Apply latest design tweaks for roundtables#376
Assignees
atelomycterus
Labels
Prod QA passQA Passtcx_Assignedtcx_FixAcceptedtcx_Paidtcx_ReadyForReview
Milestone
V1.2 Roundtables

Description

@jmgasper
jmgasper
opened on Feb 8, 2021

@atelomycterus - This is the design for the round tables:

https://marvelapp.com/prototype/c06bg41/screens

We need to apply this as best we can. Things that I see:

  1. General navigation is way simplified, especially before login (only the Roundtable option shown)
  2. The New flag is showing - can we implement that? That would be per-user, so that they know if there's a new post to a thread that they haven't seen yet.

Activity

  1. jmgasper
    added
    tcx_OpenForPickup
    on Feb 8, 2021

  2. jmgasper commented on Feb 8, 2021

    @jmgasper
    jmgasper
    on Feb 8, 2021
    CollaboratorAuthor

    Challenge https://www.topcoder.com/challenges/1dc97f47-83e5-4102-94fe-9a72d32a9bd4 has been created for this ticket.

    This is an automated message for ghostar via Topcoder X

  3. jmgasper
    assigned
    atelomycterus
    on Feb 8, 2021

  4. jmgasper commented on Feb 8, 2021

    @jmgasper
    jmgasper
    on Feb 8, 2021
    CollaboratorAuthor

    Challenge https://www.topcoder.com/challenges/1dc97f47-83e5-4102-94fe-9a72d32a9bd4 has been assigned to obog.

    This is an automated message for ghostar via Topcoder X

  5. jmgasper
    added
    tcx_Assigned
    and removed
    tcx_OpenForPickup
    on Feb 8, 2021

  6. atelomycterus commented on Feb 8, 2021

    @atelomycterus
    atelomycterus
    on Feb 8, 2021
    Contributor

    @jmgasper A few questions about the changes.

    1. I'm trying to figure out where to make changes: fix View, or update the category name in Vanilla.
      'General' category will be renamed to 'Roundtable' in DEV/PROD. Please correct me if I am wrong.
      image

    2. 'Challenges Forums' will be renamed to 'Challenge Discussion'. Please correct me if I am wrong.
      image

    3. Should 'Roundatable' be a default page for any users, not 'Recent Discussions'? Should Recent Discussions be removed from the left nav?
      I'm trying to figure out what changes should be made in Vanilla. Now the default route is Recent Discussions:
      image

    4. 01 Landing Non logged Id: What about 'Register' button ? Should I remove it from the top nav and the left nav?
      image

    5. 'New discussion' button is removed from the left nav. How users will create discussions?
      Should I remove 'Notifications' from the top nav? Removing Inbox is fine because it is not used, Removing bookmarks is fine, if bookmarks exists then the menu item ('My bookmarks') is displayed in the left nav.
      image

    6. Replies vs comments. Should I use 'comments' for consistency?
      image

    Thanks!

  7. atelomycterus commented on Feb 8, 2021

    @atelomycterus
    atelomycterus
    on Feb 8, 2021
    Contributor

    @jmgasper

    The New flag is showing - can we implement that? That would be per-user, so that they know if there's a new post to a thread that they haven't seen yet.

    'New' has been implemented in Vanilla. Need to apply design only.
    image

  8. jmgasper commented on Feb 8, 2021

    @jmgasper
    jmgasper
    on Feb 8, 2021
    CollaboratorAuthor
    1. Yes, that's fine. We'll likely have more navigational tweaks that need to happen, so the expectation is that we'll have to move stuff around.
    2. Yes, we're going to start using Discussion instead of Forum
    3. Yes, we'll default to Roundtable and remove Recent Discussions
    4. Register can be removed, yes
    5. If the user is inside a category, they'll see New Discussion. If it's difficult to control that, we can just show it on all pages
    6. Yes, we can stick with Comments
    7. Ah, got it, thanks. Yes, if we can update the design to match, that would be good.

  9. atelomycterus commented on Feb 9, 2021

    @atelomycterus
    atelomycterus
    on Feb 9, 2021
    Contributor

    @jmgasper The current status:

    TODO

    • fix breadcrumbs. Remove 'Home'
    • fix the left nav. It should display a list of categories (the first level only).
    • fix all controllers to hide Categories module.
    • fix 'New discussion' button (If the user is inside a category, they'll see New Discussion. If it's difficult to control that, we can just show it on all pages)
    • fix 'new tag''s styles
    • configure a default route. I've tried to set 'categories/roundtable' but Vanilla doesn't works for some pages. Need to fix 'index' method in Categories controller and set it as a defaultController in Routes:
      image

    Some pages have been updated:
    image

    image

    image

  10. jmgasper commented on Feb 9, 2021

    @jmgasper
    jmgasper
    on Feb 9, 2021
    CollaboratorAuthor

    Great, thanks for the update.

  11. jmgasper commented on Feb 10, 2021

    @jmgasper
    jmgasper
    on Feb 10, 2021
    CollaboratorAuthor

    @atelomycterus - From Topcoder:

    this is the latest marvel prototype with updated copy:
    https://marvelapp.com/prototype/c06bg41/screen/76613745

  12. atelomycterus commented on Feb 10, 2021

    @atelomycterus
    atelomycterus
    on Feb 10, 2021
    Contributor

    @jmgasper I'm going to test and push code tomorrow.

    Questions

    1. Should I fix minor inconsistencies between the prototype and the topcoder theme? For example:
    • font size 11/13 is used in the prototype but font size 12/14 is used in the topcoder theme
    • spaces (differences by 1-3 pixels ) and so on

    1. The old editor is used in the prototype. Are there any requirements for a view page?
      image

    2. There are several tags (closed, announcements, new).
      They have different styles. Should I apply the same design for all tags?

    Closed and New:
    image

    Announcement:
    image

    Thanks!

  13. jmgasper commented on Feb 10, 2021

    @jmgasper
    jmgasper
    on Feb 10, 2021
    CollaboratorAuthor

    Thanks for the update!

    1. If you run across any inconsistencies, if you want to log those in a new Github issue, I'll take a look, assign payment, and get that assigned out to you
    2. We can ignore any differences in the editor
    3. Yeah, this can go back to number 1 - if you just want to log that, I'll assign payment.

  14. atelomycterus commented on Feb 11, 2021

    @atelomycterus
    atelomycterus
    on Feb 11, 2021
    Contributor

    @jmgasper Ready for your review.
    Please apply PRs:

    #388
    topcoder-platform/forums-theme#21
    topcoder-platform/forums-plugins#59
    topcoder-platform/forums-groups-plugin#55

    Thanks!

    1. We can ignore any differences in the editor

    The view discussion page was recently updated by a designer in the prototype. I've applied design tweaks.

    Configuration

    DefaultController should be changed to 'categories'. The routes link is http://127.0.0.1/dashboard/routes.
    image

    Issues

    Testing

    Please clear browser cache.

  15. 9 remaining items

  16. jmgasper
    closed this as completedon Feb 12, 2021
  17. jmgasper
    added
    tcx_Paid
    tcx_ReadyForReview
    and removed
    Ready for QA
    Roundtables
    on Feb 12, 2021

  18. jmgasper commented on Feb 12, 2021

    @jmgasper
    jmgasper
    on Feb 12, 2021
    CollaboratorAuthor

    Payment task has been updated: https://www.topcoder.com/challenges/1dc97f47-83e5-4102-94fe-9a72d32a9bd4
    Payments Complete
    Winner: obog
    Copilot: ghostar
    Challenge 1dc97f47-83e5-4102-94fe-9a72d32a9bd4 has been paid and closed.

    This is an automated message for ghostar via Topcoder X

  19. sdgun commented on Feb 12, 2021

    @sdgun
    sdgun
    on Feb 12, 2021
    Collaborator

    @jmgasper @atelomycterus Don't we have to implement this?

    image

  20. atelomycterus commented on Feb 12, 2021

    @atelomycterus
    atelomycterus
    on Feb 12, 2021
    Contributor

    @sdgun yes, Challenge Discussions - #377. I am working on it.

  21. sdgun commented on Feb 12, 2021

    @sdgun
    sdgun
    on Feb 12, 2021
    Collaborator

    @jmgasper @atelomycterus

    1. Do you know the purpose of having Groups in 'Roundtables' page? When create New discussions while on Groups page they don't appear in Groups but go to the selected category.

    2. We show the 'Private' group to the anonymous users, but when they click on it to see the discussions, nothing is available

    image

    1. Marvel app doesn't have the description below on the General roundtable

    image

  22. jmgasper commented on Feb 12, 2021

    @jmgasper
    jmgasper
    on Feb 12, 2021
    CollaboratorAuthor

    @sdgun :

    1. We can log this separately
    2. We can log this separately - hopefully easy to fix
    3. We can log this separately, thanks.

  23. sdgun commented on Feb 12, 2021

    @sdgun
    sdgun
    on Feb 12, 2021
    Collaborator

    Reported:

    #392
    #391
    #390

  24. sdgun
    added
    QA Pass
    on Feb 12, 2021
  25. jmgasper
    added this to the V1.2 Roundtables milestone on Feb 22, 2021

  26. sdgun commented on Feb 22, 2021

    @sdgun
    sdgun
    on Feb 22, 2021
    Collaborator

    Verified in production.

    image

    image

  27. sdgun
    added
    Prod QA pass
    on Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Prod QA passQA Passtcx_Assignedtcx_FixAcceptedtcx_Paidtcx_ReadyForReview

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions