Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #764 +/- ##
==========================================
+ Coverage 52.37% 53.83% +1.46%
==========================================
Files 26 28 +2
Lines 3729 3845 +116
Branches 747 765 +18
==========================================
+ Hits 1953 2070 +117
+ Misses 1472 1471 -1
Partials 304 304 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
why: Find local servers without knowing their socket names and retain diagnostics for sockets that cannot answer a tmux probe. what: - Scan default directories, explicit paths, and glob patterns - Return QueryList results with metadata and object traversal - Bound probes with a command timeout that reaps expired clients
why: Verify discovery against isolated tmux servers and sockets that cannot answer a probe. what: - Cover search configuration, filtering, metadata, and traversal - Exercise stale sockets, failed probes, and client cleanup
why: Explain discovery configuration, probe results, and traversal through examples that run in the existing test suite. what: - Add contrib introduction, API reference, and executable examples - Link the lobby from the site navigation and API index - Document discovery and command timeouts in the release notes
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discover local tmux servers when their socket names are not known.
TmuxLobby.serversreturns aQueryList[TmuxLobbyServer]with socket paths, owner IDs, liveness, PID/version metadata, and access to sessions, windows, and panes. Failed probes remain queryable with an error diagnostic.Default discovery searches the current user's tmux socket directories under
/tmpandTMUX_TMPDIR, plus the socket inTMUX. Custom paths and patterns extend those locations;include_defaults=Falsereplaces them. Each access rescans, resolves socket aliases, deduplicates paths, and probes candidates sequentially without starting servers. A failed probe does not establish whether the socket belongs to tmux.Probes have a configurable one-second timeout. The supporting
Server.cmdandtmux_cmdtimeout kills and reaps the expired client while preserving the server. The probe timeout does not apply to subsequent object queries.The introduction, API reference, and executable examples live under
docs/contrib/lobby/.Validation:
A four-worker run hit the unchanged marker-capture automation doctest. That page passed separately on both the baseline and this branch; the complete two-worker run passed.