Exceptions should never be propagated as a generic Java Error

This tends to cause processes to crash as no-one catches this type of error. From what I can tell, it looks like we are re-boxing the GitlabAPIexception with a java.lang.Error.

java.lang.Error: org.gitlab.api.GitlabAPIException: {"message":"403 Forbidden"}
	at org.gitlab.api.http.GitlabHTTPRequestor$1.fetch(GitlabHTTPRequestor.java:263)
	at org.gitlab.api.http.GitlabHTTPRequestor$1.hasNext(GitlabHTTPRequestor.java:217)
	at org.gitlab.api.http.GitlabHTTPRequestor.getAll(GitlabHTTPRequestor.java:185)
	at org.gitlab.api.GitlabAPI.getRepositoryTree(GitlabAPI.java:1563)

Looking at the code really quick, I see this double try catch causing the issue:

                try {
                    HttpURLConnection connection = setupConnection(url);
                    try {
                        next = parse(connection, type, null);
                        assert next != null;
                        findNextUrl();
                    } catch (IOException e) {
                        handleAPIError(e, connection);
                    }
                } catch (IOException e) {
                    throw new Error(e);
                }

@jpitz

@jpitz you make a very good point. Would you be ok to submit a PR for this change?

I can look at putting one together. Will comment back once I have one.

…

On Dec 22, 2017, at 1:20 PM, Tim Olshansky ***@***.***> wrote: @jpitz you make a very good point. Would you be ok to submit a PR for this change? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

@timols

@timols : feel free to assign to me if possible. I should have something up today.

Pull request here: #281

gh-275: Propagate exceptions as a RuntimeException instead of java.la…

@timols

@timols ; how about spinning a new version of the library and propagating it out maven central so people can take advantage of this fix?

@timols

I see 4.1.0 out there now. Thanks @timols!

Navigation Menu

Repository navigation

Exceptions should never be propagated as a generic Java Error #275

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Exceptions should never be propagated as a generic Java Error #275

Description

Activity

mjpitz commented on Dec 18, 2017

timols commented on Dec 22, 2017

mjpitz commented on Dec 22, 2017

mjpitz commented on Jan 5, 2018

mjpitz commented on Jan 5, 2018

jaredhodge commented on Oct 4, 2018

jaredhodge commented on Oct 16, 2018

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions