Repository navigation
fix(capture): ground summaries in bounded tool outcomes - #485
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Live auto-capture previously saw tool names and inputs alongside assistant claims, without the tool results needed to qualify those claims. It now includes bounded V1/V2 textual results and invocation status in the existing summary request. The prompt distinguishes plans, attempts, failures, pending/interrupted work and observed outcomes, preserving useful failure/recovery lessons and making missing evidence explicit.
These are partial excerpts, and model summaries can still be wrong. Update rewrites are size-checked before shared-client redaction, so replacement text can expand a rewrite beyond that initial 8 KiB check. Existing external-provider history retains requests and raw responses before capture validation; separate attempts remain until existing cleanup runs (seven-day default expiry). This does not bound raw provider responses or total database size, and deleting rows need not shrink database files.
Test plan
Validation was completed in an isolated Linux cloud checkout at
17c4eb7708d460d1afc302f7968e39a08c69dc29. The exact tested patch was transferred unchanged for publication; tests were not rerun on the publishing desktop.bun test --timeout 30000: 1,162 passed, four platform-specific skips, zero failures; 8,464 assertions across 156 files.bun run build,bun run checkand patch-apply checks passed.Checklist
main(do not open PRs from commits already onmain)bun testpasses (or N/A)bun run typecheckpasses (or N/A)bun run checkpasses (format + lint + typecheck; or N/A)