Repository navigation
trickfs: move to fuser 0.18 to avoid the libfuse 3.18 mount race - #990
Merged
rphmeier merged 1 commit intoNov 18, 2026
Merged
Conversation
… CI to ubuntu-26.04
libfuse >= 3.18 passes the fusermount3 control socket by setenv()-ing
_FUSE_COMMFD in the process-wide environment and then posix_spawn()-ing
the helper with `environ`. Concurrent mounts from parallel test threads
overwrite each other's value, so a helper gets the wrong fd ("file
descriptor N is not a socket"), mounts fail with EPERM or end up handed
to the wrong session (ENOTCONN), and a caller can wait forever for an fd
that never arrives. Ubuntu 26.04 ships libfuse 3.18, hence thrumdev#984.
fuser 0.16+ mounts in pure Rust on Linux and sets _FUSE_COMMFD only on
the spawned helper, so the race cannot happen and libfuse is no longer
linked. Port trickfs to the 0.18 API: `&self` Filesystem methods (state
behind a Mutex), newtype parameters, Errno, and the Config mount API with
an explicit RootAndOwner ACL for auto_unmount.
fuser 0.18.0 does not unmount an auto_unmount session on teardown, so
umount_and_join() hangs (fixed upstream in cberner/fuser@172815c, not
released). Unmount via `fusermount3 -u -z` before joining until a fuser
release has the fix. Tests now unmount and join instead of dropping the
session, and mmap_test unmaps its mapping, which otherwise pinned the
lazily unmounted file system.
CI: run every job on ubuntu-26.04 (reverting the ubuntu-24.04 pin) and
install only `fuse3` for fusermount3; libfuse headers are no longer
needed.
Fixes thrumdev#984
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017wb3qGzNg3a3DrMB5cQJY2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pin CI to ubuntu-26.04
libfuse >= 3.18 passes the fusermount3 control socket by setenv()-ing _FUSE_COMMFD in the process-wide environment and then posix_spawn()-ing the helper with
environ. Concurrent mounts from parallel test threads overwrite each other's value, so a helper gets the wrong fd ("file descriptor N is not a socket"), mounts fail with EPERM or end up handed to the wrong session (ENOTCONN), and a caller can wait forever for an fd that never arrives. Ubuntu 26.04 ships libfuse 3.18, hence #984.fuser 0.16+ mounts in pure Rust on Linux and sets _FUSE_COMMFD only on the spawned helper, so the race cannot happen and libfuse is no longer linked. Port trickfs to the 0.18 API:
&selfFilesystem methods (state behind a Mutex), newtype parameters, Errno, and the Config mount API with an explicit RootAndOwner ACL for auto_unmount.fuser 0.18.0 does not unmount an auto_unmount session on teardown, so umount_and_join() hangs (fixed upstream in cberner/fuser@172815c, not released). Unmount via
fusermount3 -u -zbefore joining until a fuser release has the fix. Tests now unmount and join instead of dropping the session, and mmap_test unmaps its mapping, which otherwise pinned the lazily unmounted file system.CI: run every job on ubuntu-26.04 (reverting the ubuntu-24.04 pin) and install only
fuse3for fusermount3; libfuse headers are no longer needed.Fixes #984