Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When literal prompt insertion succeeds but sending Enter fails,
tmux_sendretries the full operation and inserts the prompt a second time. Track whether text was already sent and return the error without retyping it; keep the existing retry for failures before successful insertion.Add regression coverage for the Enter failure and for a first-write failure followed by a successful write and failed Enter.
Validation:
bash test/smoke.shpassed using Python 3.11.Real Codex/tmux integration was not run because tmux is unavailable on the test host. Python 3.10 smoke hits an existing
StrEnumimport failure, which is outside this patch.