Repository navigation
Feat: Ship the manifest inside the package, and prove it by building the wheel - #22
Merged
Merged
Conversation
…the wheel pythonx-map.toml sat at the repository root, outside every package directory, so the package-data pattern that names it could never pick it up -- and the re-export rule now reads it at run time, so an installed pythonx-compose would have failed on the first name it resolved. It moves to pythonx/compose/pythonx-map.toml, and every reader follows. tests/test_wheel.py builds the wheel from a copy of the sources (nothing lands in the checkout) and lists it: the manifest, the re-export rule, and an __init__.py for every mapped module must be inside. It skips, saying so, where setuptools or wheel is missing. requires-python goes from 3.8 to 3.11: the runtime reads the manifest with tomllib. The notebook-coverage test now skips where UI.ipynb is absent instead of passing with nothing checked, which AGENTS.md section 11 used to warn about. feature added: the manifest ships in the wheel. test added: test_wheel.py (3). Red before the move: 2 failed, 1 passed. test changed: the notebook-coverage test skips without the notebook. documentation corrected: README and its Korean copy (link and example path), the guide's getting-started example, SPEC S1.1 and baseline, PROJECT.md tree and baseline, AGENTS.md sections 11. Suite with ../PythonMultiplatform: 81 passed, 4 skipped -> 84 passed, 4 skipped. Without a checkout: 40 passed, 45 skipped -> 43 passed, 45 skipped (main checkout, notebook present). check_guide.py: 0. Refs #13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13
pythonx-map.tomlsat at the repository root, wherepackage-datacannot reach it, and the re-export rule (#21) reads it at run time. An installed package would have failed on the first name it resolved. The manifest moves topythonx/compose/pythonx-map.toml.Feature added: the manifest ships in the wheel.
Test added:
tests/test_wheel.pybuilds the wheel from a copy of the sources and lists it (manifest,_reexport.py, an__init__.pyper mapped module). Red before the move: 2 failed, 1 passed. It skips where setuptools/wheel are missing.Test changed: the notebook-coverage test now skips when
UI.ipynbis absent, instead of passing with nothing checked (the leader's open item 5).Packaging:
requires-pythongoes from>= 3.8to>= 3.11, because the runtime needstomllib.Documentation corrected: README (EN/KO) link and example path, guide example, SPEC S1.1 and baseline, PROJECT.md, AGENTS.md §11.
Not here:
.pyiandpy.typed(#12).../PythonMultiplatformtools/check_guide.py: 0 findings.