Repository navigation
TypedPython: emit-c CLI and manifest for pypackpack's compile slot (#25 step 1) - #372
Merged
Merged
Conversation
… step 1) python -m typedpython emit-c runs generate_project and writes a JSON manifest whose nativeModules / notNativeModules entries map one to one onto pypackpack's ExtensionModuleSource and NotNativeModule. The format (version 1) is fixed in docs/design/typedpython.md 4.3.2a for the Gradle task (#25 step 2).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #25 (step 1 of 3, approved by the lead; step 2, the Gradle task, goes to the Gradle-plugin owner).
What
python -m typedpython emit-c PATHS... --root DIR [--cache DIR] --manifest FILErunspipeline.generate_project(TypedPython: cache the generated C, not the built extension, once the pypackpack compile slot builds it #113) and writes a JSON manifest.nativeModules[i]maps to pypackpackExtensionModuleSource(moduleName, sources, includeDirs, defines);notNativeModules[i]toNotNativeModule(module, kind NOT_MARKED|NOTHING_COMPILED, items). Package__init__is in neither list. Absolute paths. Exit 0 / 1 (gate error, no manifest) / 2.pypackpack state (read only, develop c81ed5f):
ExtensionCompiler.ktholds the data types andExtensionCompilerInterfaceonly; no implementation and nonativeModulesfield in use yet.Tests