Repository navigation
TypedPython: TSan test ignores new_threadstate block reuse - #361
Merged
Merged
Conversation
…a freed block Linux CI (run 41212647289) reported tp_traced's read of an exited thread's PyThreadState racing with libpython's new_threadstate memcpy into the same reused mimalloc block; free and reuse are ordered inside the uninstrumented allocator, as in #347.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #347. Linux CI run 41212647289 (after #360) failed test_threadsanitizer_reports_nothing_on_the_extension with one report: tp_traced reading an exited thread's PyThreadState vs libpython's new_threadstate memcpy into the same reused mimalloc block. Same uninstrumented-allocator ordering as #347; the filter now also skips a report whose access is in new_threadstate. Checked against the CI report text: filtered; with the frame renamed: still counted.