Skip to content

TypedPython: decode cl.exe output in the console code page #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
b-re-w merged 1 commit into from
Oct 29, 2026
Merged

TypedPython: decode cl.exe output in the console code page #351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions python-multiplatform-ksp/src/main/python/typedpython/cbuild.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ def _find_vcvars() -> Path:
f"with C++' workload ({MSVC_COMPONENT}), or run from a 'x64 Native Tools' prompt.")
run = subprocess.run(
[str(vswhere), "-latest", "-products", "*", "-requires", MSVC_COMPONENT,
"-property", "installationPath"], capture_output=True, text=True)
"-property", "installationPath"], capture_output=True, encoding="oem", errors="replace")
root = run.stdout.strip().splitlines()[0].strip() if run.returncode == 0 and run.stdout.strip() else ""
if not root:
raise CBuildError(
Expand Down Expand Up @@ -229,7 +229,8 @@ def build(c_source: str, module_name: str, out_dir: Path, runtime_dir: Path | No
env = msvc_env()
cmd = msvc_command(_msvc_cl(env), c_file, so, include, runtime, flags,
gil_disabled=free_threaded(ext_suffix))
run = subprocess.run(cmd, capture_output=True, text=True, env=env)
# cl.exe writes in the console code page (CP949 on Korean Windows), not UTF-8
run = subprocess.run(cmd, capture_output=True, encoding="oem", errors="replace", env=env)
if run.returncode != 0 or not so.is_file():
# cl.exe reports its errors on stdout
raise CBuildError(f"C compiler failed ({run.returncode}): {subprocess.list2cmdline(cmd)}\n"
Expand Down