Repository navigation
Binder: explicit submodule import keeps the proxy class (#323) - #326
Merged
Merged
Conversation
…on its parent (#323) When the import system creates pkg.Owner through the finder it binds the module onto pkg after the loader returns, shadowing the proxy class pkg.Owner (a companion makes Owner both). The parent's module type now guards __setattr__ with class_wins_over_module, in the adapter and in PythonProxySource's per-module types, so the class stays and its __getattr__ serves the module's statics; 'import pkg.Owner as M' binds the class. Reads are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #323
Three of the four fail against the old code. The 'already loaded' case passes there too, as CPython predicts.