Repository navigation
Binder: object @Composable members and foundation.shape (#307) - #314
Merged
Merged
Conversation
…s); walk foundation.shape (#307) The walker declined an object's composable member because its thunk was a static call. The thunk now loads the object's INSTANCE and calls the member with INVOKEVIRTUAL, using the walked MethodNode's own name and descriptor (no name lookup); value-returning composables already crossed as OBJECT handles. The compose and notebook-e2e fixtures walk androidx.compose.foundation.shape, so Button/Card take shape=RoundedCornerShape__Dp(..) and colors=ButtonDefaults.buttonColors(..) / CardDefaults.cardColors(..). ComposableValueClassSlotTest now selects the top-level Icon overloads by FQN, since SegmentedButtonDefaults.Icon binds too.
…colors # Conflicts: # python-multiplatform-compose/fixtures/notebook-e2e/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #307