Repository navigation
TypedPython: memoryview buffer parameters, BufferError on resize (#149) - #299
Merged
Merged
Conversation
…nd release during a call raise BufferError (#149) SPEC states that concurrent writes from another thread are unsynchronised, as in CPython. Adds the call-heavy buffer_calls.py benchmark (list vs array.array vs memoryview); not measured yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #149
Tests: test_buffer_memoryview.py has 38 tests. It is red against develop (28 failed) and green here. A mutant without the memoryview IndexError text fails 4 of them. test_buffer_arrays: 61 passed. test_buffer_numpy: 69 passed. test_verify: 220 passed. Existing benchmarks: no memoryview annotation, so their compiled set is unchanged.