Skip to content

Fix: keep numpy buffer operations off the NEON vector path (macOS CI red since #270) #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
b-re-w merged 1 commit into from
Oct 25, 2026
Merged

Fix: keep numpy buffer operations off the NEON vector path (macOS CI red since #270) #291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion python-multiplatform-ksp/src/main/python/typedpython/cgen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1997,8 +1997,9 @@ def ok(e):
return (a is not None and a.buffer and a.type is Type.F64_ARRAY
and at_var(e.index, e.proven))
if isinstance(e, ir.BinOp):
# a numpy operation reports FP flags per element (tp_np_f64); NEON lanes do not
return (e.op in (ir.BinOpKind.ADD, ir.BinOpKind.SUB, ir.BinOpKind.MUL)
and ok(e.left) and ok(e.right))
and not e.np and ok(e.left) and ok(e.right))
if isinstance(e, ir.UnaryOp):
return e.op is ir.UnaryOpKind.NEG and ok(e.operand)
return False
Expand Down