Repository navigation
Perf: one thread-state and one TLS lookup per compiled call (#125) - #273
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #125 (option 1 of 3 unobservable improvements; direct slot access and cheaper N-11 dealloc follow).
tp_wrap_* takes PyThreadState_GetUnchecked() and the per-thread tp_tls struct (depth, poll countdown, snapshot depth, merged from three __thread variables) once and passes both down to impls, fast twins and direct callees. Py_EnterRecursiveCall/Py_LeaveRecursiveCall keep their own lookup (no public tstate variant). Recursion depth unchanged (965, same as interpreted). Test: at most one lookup per wrapper, none in impls. Tests: recursion 14, eval_breaker 8, tracing 11, runtime 264, cgen 59, fast_entry 11, str_dict 29. Timing inconclusive at load 20. Merge held for the macOS runner freeze.