This repository was archived by the owner on Jan 17, 2019. It is now read-only.
Repository navigation
Some optimization to logger - #86
Merged
Merged
Conversation
xiulipan
commented
Sep 29, 2018
Contributor
- Fix include path, will used for no-standard system and CI build
- Fix some dos format issue
- Optimize the logger similar with old rmbox
Did not include header in a absolute path. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
Change some dos format to unix Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
Add wrapper for parser function and add default path for error trace and dam trace. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
Contributor
Author
|
TODO:
Check the code find that the format is defined from switch (entry.header.params_num){
case 0:
fprintf(stdout, "%s", entry.text);
break;
case 1:
fprintf(stdout, entry.text, entry.params[0]);
break;
case 2:
fprintf(stdout, entry.text, entry.params[0],
entry.params[1]);
break;
case 3:
fprintf(stdout, entry.text, entry.params[0], entry.params[1],
entry.params[2]);
break;
} |
Member
|
@bkokoszx can you clean up the output, and align indentation. The ldc file should also be installable like the firmware binary too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.