Skip to content
This repository was archived by the owner on Jan 17, 2019. It is now read-only.

Some optimization to logger - #86

Merged
lgirdwood merged 3 commits into
thesofproject:masterfrom
xiulipan:pr/loggerfix
Sep 29, 2018
Merged

lgirdwood merged 3 commits into
thesofproject:masterfrom
xiulipan:pr/loggerfix

Conversation

@xiulipan

Copy link
Copy Markdown
Contributor
  1. Fix include path, will used for no-standard system and CI build
  2. Fix some dos format issue
  3. Optimize the logger similar with old rmbox

Did not include header in a absolute path.

Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
Change some dos format to unix

Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
Add wrapper for parser function and add default path for error
trace and dam trace.

Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
@xiulipan

Copy link
Copy Markdown
Contributor Author

TODO:
@lgirdwood @bkokoszx @akloniex

  1. copy *.ldc to target machine is pretty complex.
    May we make this as standard ABI and make it hard code into the logger?
    Or make it passed from the Firmware?

  2. some pointer value is parsed as int

20006484 0 5 117440512 1624376 ssp.c:703 coe
20006458 0 5 0 1624429 ssp.c:715 value -1043331209
2000642c 0 5 0 1624477 ssp.c:716 value -797966336

Check the code find that the format is defined from

	switch (entry.header.params_num){
	case 0:
		fprintf(stdout, "%s", entry.text);
		break;
	case 1:
		fprintf(stdout, entry.text, entry.params[0]);
		break;
	case 2:
		fprintf(stdout, entry.text, entry.params[0],
			entry.params[1]);
		break;	
	case 3:
		fprintf(stdout, entry.text, entry.params[0], entry.params[1],
			entry.params[2]);
		break;
	}

@bkokoszx @akloniex
The entry.text is defined from FW?

@xiulipan
xiulipan requested a review from lgirdwood September 29, 2018 07:15
@lgirdwood
lgirdwood merged commit 4c9498a into thesofproject:master Sep 29, 2018
@lgirdwood

Copy link
Copy Markdown
Member

@bkokoszx can you clean up the output, and align indentation.

20006484 0 5 117440512 1624376 ssp.c:703 coe
20006458 0 5 0 1624429 ssp.c:715 value -1043331209
2000642c 0 5 0 1624477 ssp.c:716 value -797966336

The ldc file should also be installable like the firmware binary too.

@xiulipan
xiulipan deleted the pr/loggerfix branch October 10, 2018 05:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants