Repository navigation
tools: change buildsystem to cmake - #951
Conversation
4815cf6 to
1850c66
Compare
Please change that (in jenkins ci), because it relies on internals of makefiles that was deleted. |
lgirdwood
left a comment
There was a problem hiding this comment.
We will also need to include changes to the sof-target -install script here to update topology & tools build dir.
Btw, how do we create a tarball release of all source files ?
There was a problem hiding this comment.
What's the prefix for destination ? I'm assuming it can be set somewhere.
There was a problem hiding this comment.
Similar to --prefix from autotools:
https://cmake.org/cmake/help/latest/variable/CMAKE_INSTALL_PREFIX.html
There was a problem hiding this comment.
Would it be better to name this build_tools ? or build/tools. Where is the "host build" target built ?
There was a problem hiding this comment.
By 'host' i guess you mean testbench that was added in FW buildsystem, because it was there previously as --enable-library(?) option. It was direct port of that, but I plan to separate testbench/fw builds.
There was a problem hiding this comment.
Also I can change build dir name to build_tools, however there is nothing else build from this project that's why I named it just build (for fw you have various builds for platfroms/ut/host so it's differnt story there).
It's missing functionality, can you create issue and write there what target name you want, for example |
|
@lgirdwood Changed as suggested. |
Done. It's #954 |
lgirdwood
left a comment
There was a problem hiding this comment.
I'm working on topology atm so will get a chance to test tomorrow.
|
@jajanusz |
e81829e to
6d0361d
Compare
|
@xiulipan @lgirdwood |
|
Is ci failure due to the ci script using autotools ? |
No, just don't believe QB tests done in the weekend (after stress tests) because it will fail every time with python tests and then @zrombel has to manually rerun them... I don't know how/when they gonna fix it ;) |
Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
6d0361d to
b2c08f5
Compare
|
@ranj063 @lgirdwood |
|
@jajanusz I'm good if you are confirming CI code scan is OK now ? |
Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
b2c08f5 to
6432170
Compare
|
@lgirdwood I did push for jenkins CI, it works, idk tho if QB build will work this time because IT servers are up and down randomly but it was ok before i rerun it |
It's ok now |
Please merge it only after someone who is actively working with tools approves it.
It should be OK I tried to directly translate rules, but I'm not sure if I didn't miss some important tools that you use every day.
How to build & install: