Skip to content

[cavs2.5-001] topology1: sof-hda-generic: enable Waves playback - #9427

Merged
mwasko merged 1 commit into
thesofproject:cavs2.5-001-drop-stablefrom
macchian:dev-waves-codec
Sep 11, 2024
Merged

mwasko merged 1 commit into
thesofproject:cavs2.5-001-drop-stablefrom
macchian:dev-waves-codec

Conversation

@macchian

@macchian macchian commented Sep 3, 2024

Copy link
Copy Markdown
Contributor

Create eq_iir + waves pipeline: pipe-eq-iir-waves-codec-playback.m4 and enable this pipeline on HDA0 for speaker/headphone playaback. HDA0.OUT dai pipeline is included for codec adapter widget connection.

@kv2019i kv2019i left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwasko to merge

@kv2019i
kv2019i requested a review from mwasko September 3, 2024 11:23
@marc-hb

marc-hb commented Sep 3, 2024

Copy link
Copy Markdown
Collaborator

Firmware failed to boot all across the board in https://sof-ci.01.org/sofpr/PR9427/build7557/devicetest/index.html

@singalsu

singalsu commented Sep 3, 2024

Copy link
Copy Markdown
Collaborator

The testbench CI failure is not related to this PR.

@marc-hb

marc-hb commented Sep 3, 2024

Copy link
Copy Markdown
Collaborator

Firmware failed to boot all across the board in https://sof-ci.01.org/sofpr/PR9427/build7557/devicetest/index.html

I think I know what's happening. It's the same rimage "bufferfly effect" that I found (and fixed) in stable-v2.2. I re-opened #9340

@macchian

macchian commented Sep 5, 2024

Copy link
Copy Markdown
Contributor Author

Firmware failed to boot all across the board in https://sof-ci.01.org/sofpr/PR9427/build7557/devicetest/index.html

I think I know what's happening. It's the same rimage "bufferfly effect" that I found (and fixed) in stable-v2.2. I re-opened #9340

@marc-hb , you are right, the #9340 fixed the issue that we verified from our end.

#
# Pipeline Endpoints for connection are :
#
# host PCM_P -- B0 --> EQIIR0 -> B1 --> Waves -- B2 --> sink DAI0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact eq-iir is only needed by dts, not by waves. pipe-waves-codec-playback is enough.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnylin76 you are right! Add Barry from Waves, @barry-waves suggest that remove the eqiir from this. Because the eqiir only requires when demux to 4ch speakers. Will update the PR soon.

@marc-hb
marc-hb removed their request for review September 11, 2024 05:06
Reuse the pipe-wave-codec-playback.m4 and
enable this pipeline on HDA0 for speaker/headphone playaback.
HDA0.OUT dai pipeline is included for codec adapter widget connection.

Signed-off-by: Mac Chiang <mac.chiang@intel.com>
@kv2019i kv2019i changed the title topology1: sof-hda-generic: enable Waves playback [cavs2.5-001] topology1: sof-hda-generic: enable Waves playback Sep 11, 2024

@lgirdwood lgirdwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwasko @abonislawski @marcinszkudlinski fyi - pls review/merge

@mwasko
mwasko merged commit 181bfe1 into thesofproject:cavs2.5-001-drop-stable Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants