Skip to content

IPC: Increase SOF_IPC_MSG_MAX_SIZE for testbench and unit test #9402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kv2019i merged 1 commit into from
Aug 27, 2024
Merged

IPC: Increase SOF_IPC_MSG_MAX_SIZE for testbench and unit test #9402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/include/ipc/header.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,8 @@ struct ipc_cmd_hdr;
/** Maximum message size for mailbox Tx/Rx */
#if CONFIG_IPC_MAJOR_4
#define SOF_IPC_MSG_MAX_SIZE 0x1000
#elif CONFIG_LIBRARY_STATIC || UNIT_TEST
#define SOF_IPC_MSG_MAX_SIZE 0x2000

@cujomalainey cujomalainey Aug 23, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How much do we care about the unit tests and libraries actually test IPC? If we care a lot then we should make this at best temporary.

@singalsu singalsu Aug 26, 2024

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests and testbench bypass most of the IPC code. The SOF plugin and testbench IPC version (still a draft PR) are using the IPC library code so they would add coverage once they are ready for usage. In short term for unit tests and testbench I don't want to care much about IPC coverage but with the new frameworks I hope it gets better.

#else
#define SOF_IPC_MSG_MAX_SIZE 384
#endif
Expand Down