Repository navigation
Audio: MFCC: Fix 64 bit build issue - #9390
Merged
kv2019i merged 1 commit intoAug 22, 2024
Merged
Conversation
singalsu
force-pushed
the
mfcc_fix_sparse_64bit_issues
branch
from
August 22, 2024 08:19
33709f1 to
a754a22
Compare
singalsu
marked this pull request as ready for review
August 22, 2024 09:29
singalsu
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
August 22, 2024 09:29
LaurentiuM1234
left a comment
LaurentiuM1234
left a comment
Contributor
There was a problem hiding this comment.
might be worth splitting into two commits as these are 2 separate issues?
kv2019i
approved these changes
Aug 22, 2024
kv2019i
left a comment
kv2019i
left a comment
Collaborator
There was a problem hiding this comment.
Please submit as two commits
lyakh
requested changes
Aug 22, 2024
| int waiting_fill:1; /**< booleans */ | ||
| int prev_samples_valid:1; | ||
| bool waiting_fill:1; /**< booleans */ | ||
| bool prev_samples_valid:1; |
Collaborator
There was a problem hiding this comment.
there's also #9385 that's fixing this bug, and it was submitted a bit earlier, but this commit fixes an additional error. Same comment as there - let's just make both these fields bool without bit-picking.
Collaborator
Author
There was a problem hiding this comment.
@cujomalainey I think I will drop this from PR and leave it for your PR to address.
The comp_err() trace in mfcc_init() causes an error:
sof/src/audio/mfcc/mfcc.c: In function 'mfcc_init':
sof/src/include/sof/audio/component.h:160:20:
error: format '%u' expects argument of type 'unsigned int',
but argument 4 has type 'size_t' {aka 'long unsigned int'}
[-Werror=format=]
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
mfcc_fix_sparse_64bit_issues
branch
from
August 22, 2024 13:40
a754a22 to
dcf7a03
Compare
singalsu
changed the title
singalsu
requested review from
LaurentiuM1234,
cujomalainey,
kv2019i and
lyakh
August 22, 2024 13:41
lyakh
approved these changes
Aug 22, 2024
LaurentiuM1234
approved these changes
Aug 22, 2024
lgirdwood
approved these changes
Aug 22, 2024
kv2019i
approved these changes
Aug 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comp_err() trace in mfcc_init() causes an error:
sof/src/audio/mfcc/mfcc.c: In function 'mfcc_init': sof/src/include/sof/audio/component.h:160:20:
error: format '%u' expects argument of type 'unsigned int',
but argument 4 has type 'size_t' {aka 'long unsigned int'}
[-Werror=format=]