Repository navigation
app/stub_build_all_ipc3/4.conf: enable CONFIG_CADENCE_CODEC - #9312
Merged
Merged
Conversation
This change enables CONFIG_CADENCE_CODEC in the app/stub_build_all_ipc3/4.conf files. With this, the Cadence Codec component will be included in builds for CI testing. Signed-off-by: Anne Onciulescu <anne.onciulescu@gmail.com>
AnneOnciulescu
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
July 18, 2024 15:06
Collaborator
|
Can one of the admins verify this patch?
|
Collaborator
test this please |
andyross
approved these changes
Jul 18, 2024
andyross
left a comment
andyross
left a comment
Contributor
There was a problem hiding this comment.
Hah, simple. Very nice.
dbaluta
approved these changes
Jul 18, 2024
iuliana-prodan
approved these changes
Jul 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #9292.
Changes:
app/stub_build_all_ipc3.conf.app/stub_build_all_ipc4.conf.With this, the Cadence Codec component will be included in builds for CI testing.
Additional stub implementation is not necessary for building due to the way function pointers and the API_CALL macro handle the proprietary libraries in
src/audio/module_adapter/module/cadence.c.