Repository navigation
audio: host: reload DMA when partial_size is non zero - #8743
Merged
lgirdwood merged 1 commit intoJan 18, 2024
Merged
Conversation
dnikodem
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
January 16, 2024 10:58
dnikodem
force-pushed
the
reload_dma_if_partial_size_non_zero
branch
2 times, most recently
from
January 16, 2024 11:29
b27051b to
ba612d9
Compare
kv2019i
requested changes
Jan 16, 2024
kv2019i
left a comment
kv2019i
left a comment
Collaborator
There was a problem hiding this comment.
Some comments inline, please check
| @@ -449,8 +449,20 @@ static int host_copy_normal(struct host_data *hd, struct comp_dev *dev, copy_cal | |||
| comp_dbg(dev, "host_copy_normal()"); | |||
Collaborator
There was a problem hiding this comment.
On the commit message, the git commit prefix should refer to the component changed, i.e. here "audio: host: ".
Could you explain a bit in which case this happens. "src" -> resampler case?
Contributor
Author
There was a problem hiding this comment.
Kai, thanks for feedback.
Regarding the commit message, I will make a correction to specify the component as "audio: host."
Regarding the scenario in which this could happen:
This condition typically occurs at the end of a stream, where the last data chunk does not meet the condition for reload DMA buffer (e.g., large buffers), leaving a non-zero partial_size.
|
|
||
| hd->partial_size = 0; | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
This seems to duplicate the logic at the end of the functions, so how about instaed:
if (copy_bytes)
cb(dev, copy_bytes);
if (!hd->partial_bytes)
return 0;
And let the existing code to call dma_reload at the end of the function.
Collaborator
There was a problem hiding this comment.
@dnikodem Ack, so above won't work with CONFIG_HOST_DMA_RELOAD_DELAY_ENABLE=y and if we get repeated calls copy_bytes==0 (stream is ending). So back to original version (with just the commit message clarified) is ok to me
Collaborator
|
Another DSP panic on suspend/resume. We seem to somehow get better and collecting logs on suspend/resume failures as opposed to just TIMEOUTs. Probably unrelated to this PR. EDIT: looks similar to DSP panic #8721 which was bisected. |
marc-hb
added
the
suspend-resume
This patch ensures that the DMA buffer is reloaded when partial_size is non-zero, even if copy_bytes is zero. This condition typically occurs at the end of a stream, where the last data chunk does not meet the condition for reload DMA buffer, leaving a non-zero partial_size. Signed-off-by: Damian Nikodem <damian.nikodem@intel.com>
dnikodem
force-pushed
the
reload_dma_if_partial_size_non_zero
branch
from
January 17, 2024 10:15
ba612d9 to
bc7f5f3
Compare
kv2019i
approved these changes
Jan 17, 2024
dnikodem
changed the title
lgirdwood
approved these changes
Jan 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When partial_size is non-zero and copy_bytes equals zero, the DMA buffer should be reloaded. Otherwise, the DMA status registers will indicate incorrect values.