Repository navigation
topology2/cmake: extract new function "alsatplg_version()" for re-use - #8358
Merged
Merged
Conversation
We want to fail if STATUS is not defined, the empty string, the FALSE string or anything unexpected that it is not strictly equal to success code "0". Fixes commit 308a24a ("topology2: Add build support") Signed-off-by: Marc Herbert <marc.herbert@intel.com>
We'll use this new function to require ALSA 1.2.5 and finally rename to "codec_consumer" (see revert discussion thesofproject#5192) Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
force-pushed
the
alsatplg-func
branch
from
October 19, 2023 23:39
413154d to
2b3f19a
Compare
marc-hb
marked this pull request as ready for review
October 20, 2023 02:22
Collaborator
Author
|
topologies build verified OK in internal logs sof_config_build/5603 Only suspend/resume failures in ACE https://sof-ci.01.org/sofpr/PR8358/build212/devicetest/index.html and CAVS https://sof-ci.01.org/sofpr/PR8358/build213/devicetest/index.html |
marc-hb
requested review from
aiChaoSONG,
fredoh9,
kv2019i,
lyakh,
plbossart,
ranj063 and
singalsu
October 20, 2023 02:23
kv2019i
approved these changes
Oct 20, 2023
lgirdwood
approved these changes
Oct 20, 2023
Collaborator
Author
|
SOFCI TEST |
Collaborator
Author
|
Tools compilation is visible again and working fine in https://sof-ci.01.org/sofpr/PR8358/build13983/build/index.html Irrelevant https://sof-ci.01.org/sof-pr-viewer/#/build/PR8358/build12988341 is green. ACE https://sof-ci.01.org/sofpr/PR8358/build13984/devicetest/index.html is all green |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'll use this new function to require ALSA 1.2.5 and finally rename to
"codec_consumer" (see revert discussion #5192)