Skip to content

audio: google_rtc: Remove set_large_config op for IPC4 - #8172

Merged
kv2019i merged 1 commit into
thesofproject:mainfrom
ranj063:fix/google_aec_ipc4
Sep 7, 2023
Merged

kv2019i merged 1 commit into
thesofproject:mainfrom
ranj063:fix/google_aec_ipc4

Conversation

@ranj063

@ranj063 ranj063 commented Sep 6, 2023

Copy link
Copy Markdown
Collaborator

The input and output audio formats are sent during module init already. So no need to overwrite it with topology data that could be incorrect.

The input and output audio formats are sent during module init already.
So no need to overwrite it with topology data that could be incorrect.

Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
@ranj063
ranj063 requested a review from a team as a code owner September 6, 2023 19:37
@kv2019i

kv2019i commented Sep 7, 2023

Copy link
Copy Markdown
Collaborator

Code looks good. Unexpected fails in https://sof-ci.01.org/sofpr/PR8172/build12671/devicetest/index.html -- can't immediately see how these can be connected to this PR, but needs to be investigated before merge.

@kv2019i

kv2019i commented Sep 7, 2023

Copy link
Copy Markdown
Collaborator

One case fails on MTL to

[   10.829523] <err> dai_comp: dai_common_new: comp:1 0x10004 dai_new(): dai_get() failed to create DAI.
[   10.829531] <err> copier: copier_dai_create: comp:1 0x10004 failed to create dai
[   10.829538] <err> copier: copier_init: comp:1 0x10004 unable to create dai
[   10.829548] <err> module_adapter: module_init: comp:1 0x10004 module_init() error -19: module specific init failed, comp id 65540
[   10.829568] <err> module_adapter: module_adapter_new: comp:1 0x10004 module_adapter_new() -19: module initialization failed
[   10.829585] <err> ipc: ipc4_init_module_instance: error: failed to init module 4 : 1
[   10.829591] <err> ipc: ipc_cmd: ipc4: MODULE_MSG failed with err 104

Topology is of-mtl-rt711-4ch.tplg , so it doesn't have the RTC component. Strange this is we have not seen this with any other PR (at least recently). Let me run this again to confirm there's no connection to this PR that I can't see.

@kv2019i

kv2019i commented Sep 7, 2023

Copy link
Copy Markdown
Collaborator

SOFCI TEST

@kv2019i

kv2019i commented Sep 7, 2023

Copy link
Copy Markdown
Collaborator

Pass now, merging.

@kv2019i
kv2019i merged commit 2c6c1b4 into thesofproject:main Sep 7, 2023
@ranj063
ranj063 deleted the fix/google_aec_ipc4 branch September 7, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants