Repository navigation
audio: google_rtc: Remove set_large_config op for IPC4 - #8172
Merged
Merged
Conversation
The input and output audio formats are sent during module init already. So no need to overwrite it with topology data that could be incorrect. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
yongzhi1
approved these changes
Sep 6, 2023
btian1
reviewed
Sep 7, 2023
kv2019i
approved these changes
Sep 7, 2023
Collaborator
|
Code looks good. Unexpected fails in https://sof-ci.01.org/sofpr/PR8172/build12671/devicetest/index.html -- can't immediately see how these can be connected to this PR, but needs to be investigated before merge. |
Collaborator
|
One case fails on MTL to Topology is of-mtl-rt711-4ch.tplg , so it doesn't have the RTC component. Strange this is we have not seen this with any other PR (at least recently). Let me run this again to confirm there's no connection to this PR that I can't see. |
Collaborator
|
SOFCI TEST |
Collaborator
|
Pass now, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The input and output audio formats are sent during module init already. So no need to overwrite it with topology data that could be incorrect.