Skip to content

Kconfig.zephyr: check priorities off #8096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pjdobrowolski wants to merge 1 commit into from
Closed

Kconfig.zephyr: check priorities off #8096

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions zephyr/Kconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,14 @@ config ZEPHYR_DP_SCHEDULER
DP modules can be located in dieffrent cores than LL pipeline modules, may have
different tick (i.e. 300ms for speech reccognition, etc.)

config CHECK_INIT_PRIORITIES

@kv2019i kv2019i Aug 25, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the right way. We can just set this to 'n' in the in sof/app/prj.conf

But we can't do this until the we update to latest Zephyr mainline and take in this patch

commit 058f256ea140026e46e458dd51036ea2c1f81b2a
Author: Fabio Baltieri <fabiobaltieri@google.com>
Date:   Fri Mar 10 17:26:35 2023 +0000

    Kconfig.zephyr: check priorities by default

Then you'll get errors like this:
https://github.com/thesofproject/sof/actions/runs/5973406935/job/16205619385?pr=8095

@pjdobrowolski pjdobrowolski Aug 25, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about that and we should do it as soon as possible. Is there any arguments against update?

@kv2019i kv2019i Aug 25, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pjdobrowolski no obstacles, we can do one immediately. I just merged a 2200+ commit update yesterday, so we are very close to Zephyr mainline already so I don't expect many (new) issues beside this priority level check.

We need to investigate the priority check warnings as well and why those fail for us.

@marc-hb marc-hb Aug 26, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about that and we should do it as soon as possible.

We must do it in the same commit where we update the Zephyr manifest and get this new feature. Neither before nor after to make sure every SOF commit builds.

If you need a local workaround in the mean time then west config build.cmake-args -- -DCONFIG_CHECK_INIT_PRIORITIES=n is probably the most convenient?

I just merged a 2200+ commit update yesterday,

This sort of number can be deceiving; these could be almost all in drivers that we'll never use.

bool "Build time initialization priorities check"
default n
help
Check the build for initialization priority issues by comparing the
initialization priority in the build with the device dependency
derived from the devicetree definition.
Fails the build on priority errors (dependent devices, inverted
priority), see CHECK_INIT_PRIORITIES_FAIL_ON_WARNING to fail on
warnings (dependent devices, same priority) as well.
endif