Skip to content

Dockerfile: add AMD/Vangogh gcc toolchain - #7936

Merged
lgirdwood merged 1 commit into
thesofproject:mainfrom
saisurya-ch:vangoogh_docker
Jul 14, 2023
Merged

Dockerfile: add AMD/Vangogh gcc toolchain#7936
lgirdwood merged 1 commit into
thesofproject:mainfrom
saisurya-ch:vangoogh_docker

Conversation

@saisurya-ch

@saisurya-ch saisurya-ch commented Jul 13, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Add AMD/Vangogh gcc toolchain in Dockerfile.

@saisurya-ch
Dockerfile: add AMD/Vangogh gcc toolchain
6356c6c 
Add AMD/Vangogh gcc toolchain.

Signed-off-by: SaiSurya Ch <saisurya.chakkaveeravenkatanaga@amd.com>
@saisurya-ch saisurya-ch mentioned this pull request Jul 13, 2023
Merged
@dbaluta

dbaluta commented Jul 13, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

One thing to notice is that for previous AMD boards you used short form rn rmb and now vangogh long form. But other than that looks good to me.

@kv2019i

kv2019i commented Jul 13, 2023

Copy link
Copy Markdown
Collaborator

@marc-hb or @fredoh9 , can one of you ack?

@saisurya-ch

saisurya-ch commented Jul 13, 2023

Copy link
Copy Markdown
Member Author

One thing to notice is that for previous AMD boards you used short form rn rmb and now vangogh long form. But other than that looks good to me.

There is no short form defined for the vangogh platform in our organization, we are using the keyword 'vangogh' itself.

lgirdwood
lgirdwood approved these changes Jul 13, 2023
View reviewed changes

@lgirdwood lgirdwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kv2019i @marc-hb reminds me we need to remove old Intel platforms after this PR is merged.

@lgirdwood
lgirdwood requested a review from marc-hb July 13, 2023 12:32
@marc-hb
marc-hb requested a review from fredoh9 July 13, 2023 13:38
@marc-hb

marc-hb commented Jul 13, 2023

Copy link
Copy Markdown
Collaborator

@kv2019i @marc-hb reminds me we need to remove old Intel platforms after this PR is merged.

If you look at the git log you can see this was done by @lyakh (probably without testing) and then it took a significant effort to undo it so we don't have to branch the docker image for stable-v2.2. Let's please not go through that again :-)

@lgirdwood

lgirdwood commented Jul 14, 2023

Copy link
Copy Markdown
Member

@fredoh9 is out. Lets take this forward.

@lgirdwood
lgirdwood merged commit 2475094 into thesofproject:main Jul 14, 2023
@fredoh9

fredoh9 commented Jul 17, 2023

Copy link
Copy Markdown
Contributor

I have started the build for new docker image. I will update the docker image tomorrow.

@fredoh9

fredoh9 commented Jul 17, 2023

Copy link
Copy Markdown
Contributor

As of 2:30 PM PST, thesofproject/sof:latest_ubuntu22.04 has this change
Different tag is thesofproject/sof:20230716_ubuntu22.04.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbaluta dbaluta dbaluta approved these changes
@lgirdwood lgirdwood lgirdwood approved these changes
@btian1 btian1 btian1 approved these changes
@kv2019i kv2019i kv2019i approved these changes
@bhiregoudar bhiregoudar bhiregoudar approved these changes
@sunilkumardommati sunilkumardommati sunilkumardommati approved these changes
@ranj063 ranj063 Awaiting requested review from ranj063
@plbossart plbossart Awaiting requested review from plbossart plbossart is a code owner
@mmaka1 mmaka1 Awaiting requested review from mmaka1 mmaka1 is a code owner
@lbetlej lbetlej Awaiting requested review from lbetlej lbetlej is a code owner
@marc-hb marc-hb Awaiting requested review from marc-hb
@fredoh9 fredoh9 Awaiting requested review from fredoh9

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@saisurya-ch @dbaluta @kv2019i @marc-hb @lgirdwood @fredoh9 @btian1 @bhiregoudar @sunilkumardommati