Skip to content

audio: delete switch component - #7932

Merged
lgirdwood merged 1 commit into
thesofproject:mainfrom
cujomalainey:switch
Jul 14, 2023
Merged

lgirdwood merged 1 commit into
thesofproject:mainfrom
cujomalainey:switch

Conversation

@cujomalainey

Copy link
Copy Markdown
Contributor

mostly not implemented and hasn't been meaningfully touched in > 3 yr.

@btian1 btian1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's an empty component, delete it make sense.

Comment thread src/audio/CMakeLists.txt Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but we keep CONFIG_COMP_SWITCH ?

@lgirdwood lgirdwood Jul 13, 2023 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never used, we can remove and reclaim in future if needed.

@lgirdwood lgirdwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack never used - @cujomalainey can be removed from kernel too.

@dbaluta

dbaluta commented Jul 13, 2023

Copy link
Copy Markdown
Collaborator

@cujomalainey there are some more references to CONFIG_COMP_SWITCH. Can we remove those also?

src/arch/xtensa/configs/mt8186_defconfig:CONFIG_COMP_SWITCH=n
src/arch/xtensa/configs/mt8188_defconfig:CONFIG_COMP_SWITCH=n
src/arch/xtensa/configs/mt8195_defconfig:CONFIG_COMP_SWITCH=n
src/arch/xtensa/configs/override/tigerlake_chrome_google_aec.config:CONFIG_COMP_SWITCH=n
src/arch/xtensa/configs/override/tigerlake_chrome_waves_google_aec.config:CONFIG_COMP_SWITCH=n
src/arch/xtensa/configs/rembrandt_defconfig:CONFIG_COMP_SWITCH=n
src/audio/CMakeLists.txt:       if(CONFIG_COMP_SWITCH)
zephyr/CMakeLists.txt:zephyr_library_sources_ifdef(CONFIG_COMP_SWITCH

mostly not implemented and hasn't been meaningfully touched in > 3 yr.

Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
@cujomalainey

Copy link
Copy Markdown
Contributor Author

@cujomalainey there are some more references to CONFIG_COMP_SWITCH. Can we remove those also?

Nice catch, thanks I was grepping at src/audio. Fixed now

@kv2019i

kv2019i commented Jul 13, 2023

Copy link
Copy Markdown
Collaborator

Looks good to go. Let's wait for the CI results. It seems we have an issue with SOF and Zephyr mainline again. Won't block this PR, but something we need to address.

@marc-hb

marc-hb commented Jul 14, 2023

Copy link
Copy Markdown
Collaborator

It seems we have an issue with SOF and Zephyr mainline again.

It's not Zephyr actually, just SOF. Tentative fix submitted in #7945

@lgirdwood
lgirdwood merged commit 9d51b5c into thesofproject:main Jul 14, 2023
@cujomalainey
cujomalainey deleted the switch branch July 14, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants