Repository navigation
platform: cavs: remove hw init in platform_init() on sof side - #7896
Conversation
RanderWang
changed the title
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
Lets delete the IP programming code after first checking its in Zephyr for each target.
These registers are set in power_init() in zephyr layer, so remove redundant setting and remove hw setting in SOF layer. Signed-off-by: Rander Wang <rander.wang@intel.com>
These hw clk settings are done in zephyr layer in power_init(), so remove them in sof side. The CONFIG_CAVS_LPRO_ONLY is for CoffeeLake only and doesn't affect TigerLake, so the hw clk settings are the same for platform_init and power_init(), then we can remove them. Signed-off-by: Rander Wang <rander.wang@intel.com>
81424f9 to
3acdf10
Compare
|
redundant code remove are always welcome, repeated operation may cause un-expected situation for DSP. |
|
@lgirdwood removed HW setting, thanks! |
286e5b3 to
61e1fb1
Compare
CONFIG_CAVS_LPRO_ONLY is only for CoffeeLake and is not fit for current IPC4 main branch, so remove it to make code clean. Signed-off-by: Rander Wang <rander.wang@intel.com>
61e1fb1 to
87290fe
Compare
| #if CONFIG_CAVS_LPRO_ONLY | ||
| #define CAVS_DEFAULT_RO SHIM_CLKCTL_RLROSCC | ||
| #define CAVS_DEFAULT_RO_FOR_MEM SHIM_CLKCTL_OCS_LP_RING | ||
| #else |
There was a problem hiding this comment.
So this commit was wrong? It seems to suggest that LPRO was also available for cAVS 2.0 034c54a
There was a problem hiding this comment.
I deleted CONFIG_CAVS_LPRO_ONLY which is for debugging only at the moment, choose n if unclear
There was a problem hiding this comment.
yeah, that was just a renaming in 59c3315 so from those commits it looks like this was a debug option also available for TGL. It's ok if we remove it because we don't need or don't want it any more, but at least I don't see that it was only available for CFL
There was a problem hiding this comment.
@lyakh I did involved in this feature and you may recall it. In 2019, we found a HW hang on HDA platform only on CFL and debugged it for almost a month, finally confirmed by HW team that we need to use LPO for HW restraint. But we don't need it for CML and successor HW platform.
There was a problem hiding this comment.
Ok, good, maybe it would just be a bit clearer if we said something like "remove this debug option because we don't need it any more" in the commit message - just by looking at the patch nothing in it explains why it's only relevant up to CFL
It is for [FEATURE][Zephyr] Move all hw init code from platform_init() to Zephyr #5602
Tested on TGL RVP & UPX