Skip to content

Convert copier to use the module interface #7890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgirdwood merged 12 commits into from
Jul 13, 2023
Merged

Convert copier to use the module interface #7890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8355b95
module_adapter: Extend the module interface
ranj063 May 31, 2023
7e30fdc
module_adapter: Extend the module interface for endpoint devices
ranj063 May 31, 2023
7806392
audio: module_adapter: Prepare to convert copier to use module interface
ranj063 Jul 4, 2023
a581267
audio: volume: Remove state check
ranj063 Jul 9, 2023
29acc88
audio: module_adapter: Isolate the module state checks to IPC3
ranj063 Jul 9, 2023
6bcaf89
audio: copier: Convert module to use module interface
ranj063 Jul 4, 2023
d3055f9
ipc4: base-config: Expose ipc4_base_module_cfg_to_stream_params()
ranj063 Jul 7, 2023
44ec642
audio: module_adapter: Update stream params
ranj063 Jul 7, 2023
79d82aa
ipc4: Expose ipc4_update_buffer_format()
ranj063 Jul 7, 2023
057c46f
audio: asrc: Fix a typo
ranj063 Jul 7, 2023
746fc2b
audio: asrc: Update stream params from base config
ranj063 Jul 7, 2023
d6e4583
audio: volume: Simplify volume_params()
ranj063 Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/audio/asrc/asrc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,9 +539,13 @@ static int asrc_params(struct comp_dev *dev,

comp_info(dev, "asrc_params()");

#if CONFIG_IPC_MAJOR_4
ipc4_base_module_cfg_to_stream_params(&cd->ipc_config.base, pcm_params);
#endif

err = asrc_verify_params(dev, pcm_params);
if (err < 0) {
comp_err(dev, "src_params(): pcm params verification failed.");
comp_err(dev, "asrc_params(): pcm params verification failed.");
return -EINVAL;
}

Expand All @@ -553,6 +557,12 @@ static int asrc_params(struct comp_dev *dev,
source_c = buffer_acquire(sourceb);
sink_c = buffer_acquire(sinkb);

#if CONFIG_IPC_MAJOR_4
/* update the source/sink buffer formats. Sink rate will be modified below */
ipc4_update_buffer_format(source_c, &cd->ipc_config.base.audio_fmt);
ipc4_update_buffer_format(sink_c, &cd->ipc_config.base.audio_fmt);
#endif

@lyakh lyakh Jul 12, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here - what's the effect of these changes?

@ranj063 ranj063 Jul 12, 2023

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same explanation, copier doesnt set the source/sink buffer until prepare. So asrc_params( will fail without it


/* Don't change sink rate if value from IPC is 0 (auto detect) */
if (asrc_get_sink_rate(&cd->ipc_config))
audio_stream_set_rate(&sink_c->stream, asrc_get_sink_rate(&cd->ipc_config));
Expand Down
Loading