Repository navigation
dma channel management fixes - #786
Merged
Merged
Conversation
For dais, we don't support change dma channel dynamically, so only get dma channel at first config, ignore that for latter dai_config invokings to avoid dma channel leaking. Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
This will be helpful for error reporting at host dma channel management. Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
keyonjie
requested review from
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
January 2, 2019 09:48
Collaborator
|
This issue is caused by kernel driver. I agree with keyon to protect dma in FW. |
RanderWang
reviewed
Jan 3, 2019
RanderWang
left a comment
RanderWang
left a comment
Collaborator
There was a problem hiding this comment.
how about dai_reset()?
Collaborator
|
please refer to PR in kernel: thesofproject/linux#472 |
Contributor
Author
|
@RanderWang dma channel is put in dai_free(), so I didn't reset dd->chan at reset, we should only reset it after channel is put. Maybe we need move channel put to dai_reset() actually. |
Contributor
Author
|
@lgirdwood ping. |
lgirdwood
approved these changes
Jan 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This series is only minor changes to fix a dma channel exhausted issue that happens at suspend/resume.
We get dma channels at dai_config() for dai component, but this might be called several times and the previous got channels are leak at that case.