Skip to content

Use mimx93_evk_a55 board for SOF also - #7829

Merged
dbaluta merged 4 commits into
thesofproject:mainfrom
dbaluta:imx93_support
Jun 21, 2023
Merged

dbaluta merged 4 commits into
thesofproject:mainfrom
dbaluta:imx93_support

Conversation

@dbaluta

@dbaluta dbaluta commented Jun 19, 2023 •

Copy link
Copy Markdown
Collaborator

We previously created a synthetic board named mimx93_evk_a55_sof but this is not a good direction to take.

We need to use the default board mimx93_evk_a55 and adapt it to SOF using dts overlays and Kconfig fragments.

After these patches we can build SOF firmware image for A55 using:

west build -p --board mimx93_evk_a55  modules/audio/sof/app

dbaluta added 2 commits June 19, 2023 15:35
We will use SOF app with default mimx93_evk_a55 board on top
of which will add necessary adaptations.

e.g we will define SOF required memory areas in the overlay
and will get rid of mimx93_evk_a55_sof board.

Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
We plan to get rid of mimx93_evk_a55_sof board and use the
generic mimx93_evk_a55 board + overlays.

This patch adds the config fragment to enable mimx93_evk_a55 board for
SOF.

Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>

@LaurentiuM1234 LaurentiuM1234 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Assuming mimx93_evk_a55_sof will be removed from Zephyr don't forget to also update LP64 CI which uses it. Currently, things are a bit weird IMO with the mmu_regions.c using the regions from the overlay but these regions will be removed anyways when the support for native drivers is added. Out of curiosity: did you also try building SOF from Zephyr side using these changes?

@dbaluta

dbaluta commented Jun 20, 2023 •

Copy link
Copy Markdown
Collaborator Author

Out of curiosity: did you also try building SOF from Zephyr side using these changes?

I only build SOF from Zephyr side like this:

#  clone zephyr repo, run west init, west update
# build zephyr.bin
$ west build -p --board mimx93_evk_a55  modules/audio/sof/app

Do you remember where was the L64 CI PR that added this support.

Also, thinking about this. I wonder if we shouldn't somehow used 32bits for SOF FW with a55. As an experiment using 64 bits is fine.

But I think for a more practical usecases when imx95 will arrive we should compile SOF firmware for a55 core with 32 bits support rather than 64 bits.

We don't really need 64 bits and we also save some space.

@LaurentiuM1234

Copy link
Copy Markdown
Contributor

Do you remember where was the L64 CI PR that added this support.

#7772

Also, thinking about this. I wonder if we shouldn't somehow used 32bits for SOF FW with a55. As an experiment using 64 bits is fine.

But I think for a more practical usecases when imx95 will arrive we should compile SOF firmware for a55 core with 32 bits support rather than 64 bits.

We don't really need 64 bits and we also save some space.

This will require some experimentation. Zephyr seems to compile arm64 binaries using the lp64 flag atm so we'll have to watch out for this too.

dbaluta added 2 commits June 20, 2023 17:45
We now use mimx93_evk_a55 board so there is no longer
need for mimx93_evk_a55_sof.conf.

Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
We no longer use synthetic mimx93_a55_evk_sof board but
rather we customize already existing proper mimx93_a55_evk board.

Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
@dbaluta

dbaluta commented Jun 20, 2023 •

Copy link
Copy Markdown
Collaborator Author

@iuliana-prodan @LaurentiuM1234

Changes since v1:

  • removed mimx93_a55_evk_sof board conf file
  • fixed .github action for compiling lp64

@kv2019i

kv2019i commented Jun 21, 2023

Copy link
Copy Markdown
Collaborator

@dbaluta Feel free to merge.

@dbaluta
dbaluta merged commit a5dcd86 into thesofproject:main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants