Repository navigation
Fix Nocodec capture PCM ID - #7747
Merged
Merged
Conversation
ranj063
force-pushed
the
fix/nocodec_module_copier
branch
2 times, most recently
from
June 6, 2023 18:09
d5ff21e to
28c8e96
Compare
And fix the erroneous PCM ID for SSP0 capture. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
ranj063
force-pushed
the
fix/nocodec_module_copier
branch
from
June 6, 2023 18:45
28c8e96 to
5b3aa04
Compare
plbossart
reviewed
Jun 6, 2023
| PASSTHROUGH "false" | ||
| SSP0_PCM_NAME "Port0" | ||
| SSP0_CAPTURE_PCM "Port0 2nd Capture" | ||
| SSP0_CAPTURE_PCM_ID 12 |
Member
There was a problem hiding this comment.
why isn't this zero? I don't get this.
Collaborator
Author
There was a problem hiding this comment.
There are 2 capture PCMs, @plbossart . Pcm0 and pcm12
Collaborator
Author
There was a problem hiding this comment.
You can see the 2 PCM names just above
Member
There was a problem hiding this comment.
if SSP0_CAPTURE_PCM is about a 2nd part, why isn't the naming a bit self-explanatory, e.g. SSP0_2ND_CAPTURE_PCM?
Collaborator
Author
There was a problem hiding this comment.
I kept it consisten with the PCM name on line 86
juimonen
approved these changes
Jun 7, 2023
juimonen
left a comment
juimonen
left a comment
There was a problem hiding this comment.
fine by me. we starting to have quite extensive list of defines....
Collaborator
|
Known fail in https://sof-ci.01.org/sofpr/PR7747/build9062/devicetest/index.html on one DUT, not related to this PR. Proceeding with merge. |
kv2019i
approved these changes
Jun 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.