Repository navigation
[IPC4] Enable core dump - #7726
Conversation
9eee98e to
58d5b11
Compare
|
@kv2019i Very sorry that I missed "arch_system_halt" in your original patch. I can't recall the reason. |
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Thank you @RanderWang , looks good!
juimonen
left a comment
juimonen
left a comment
There was a problem hiding this comment.
lgtm, just probable typo in "copules time"
|
@RanderWang I think you need to declare the shutdown somehow: https://github.com/thesofproject/sof/actions/runs/5142711830/jobs/9257018685?pr=7726 I wonder if there's some more public function to do the same. Otherwise looks we are ready to go. |
There was a problem hiding this comment.
maybe it is used for waiting GDB attach
There was a problem hiding this comment.
We are overriding the Zephyr panic handlers here, so we do need to halt the system here, whether it's debug or not.
Follow the k_sys_fatal_error_handler implementation in fatal.c in zephyr framework. Without this halt, our k_sys_fatal_error_handler will be called copules time and result to many useless IPC messages to host. Signed-off-by: Rander Wang <rander.wang@intel.com>
We need to enable CONFIG_DEBUG_COREDUMP_MEMORY_DUMP_MIN according to comments in coredump_core.c: When dumping minimum information, the current thread struct and stack need to be dumped so debugger can examine them. Signed-off-by: Rander Wang <rander.wang@intel.com>
Follow the setting on TGL platforms. Signed-off-by: Rander Wang <rander.wang@intel.com>
58d5b11 to
d54d921
Compare
|
@kv2019i fixed. Thanks! |
|
This seems to have unexpected sideeffect that coredump to logging subsystem got disabled when we enable the window dump. Impact analysis ongoing. UPDATE: it's not completely disabled, panic is still written to log, but for some reason, the last bits are omitted in the log when coredump to window is enabled. So potentially something with flushing the mtrace buffer. |
Enable core dump on TGL & MTL. When FW panic happen, zephyr will dump panic information in debug window, then Linux kernel can get this dump info