Repository navigation
Modify the naming convention for the host copier in topology - #7631
Merged
Merged
Conversation
ranj063
changed the title
Collaborator
Author
|
SOFCI TEST |
plbossart
reviewed
May 17, 2023
plbossart
left a comment
plbossart
left a comment
Member
There was a problem hiding this comment.
I guess I am not fully getting the idea for the copier input/output pins, and I also wonder about replacing the macros with open-coding, see below @ranj063.
The replacement looks mostly good otherwise, I didn't spot any major issues.
Member
There was a problem hiding this comment.
are you trying to say that one of 'num_input_pins' and 'num_output_pins" shall be zero?
Collaborator
Author
There was a problem hiding this comment.
i've removed the default values and mandatory attributes for both. num_input_pins and num_output_pins come into the picture only where there're more than 1. Otherwise, they're just ignored by the kernel driver and in all our topologies today we dont have more than 1 of these for playback/capture.
Collaborator
Author
There was a problem hiding this comment.
ANd I was wrong about this. So I've fixed all host-copiers to have the right number of input/output pins based on direction
Member
There was a problem hiding this comment.
what is the host-copier connected to on playback?
Member
There was a problem hiding this comment.
what is the host-copier connected to on capture?
This was referenced May 17, 2023
bardliao
reviewed
May 18, 2023
bardliao
approved these changes
May 18, 2023
plbossart
reviewed
May 18, 2023
plbossart
left a comment
plbossart
left a comment
Member
There was a problem hiding this comment.
Still confused on pin definitions...
… gateway This will replace the generic copier for the host gateway. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Replace the generic copier with host-copier object in the pipeline class definition and all its instances. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Replace the generic copier with host-copier in the class definition and the instances. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Replace the generic copier with host-copier in the class definition and the instances. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Replace the generic copier with host-copier in the class definition and the instances. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Replace the generic copier with host-copier in the class definition. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Replace the generic copier with host-copier in the class definition and the instances. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Replace the generic copier with host-copier in the class definition. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Replace the generic copier with host-copier in the class definition and the instances. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Replace the generic copier with host-copier in the class definition and the instances. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Replace the generic copier with host-copier in the class definition and the instances. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
It is now handled by the host-copier class. Renaming the copier class to dai-copier and modifying its naming convention will be done in the follow up patches. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
plbossart
approved these changes
May 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The names for the host copier have been changed from the current convention of copier.host.<PIPELINE_ID>.<INSTANCE_ID> to host-copier.<PCM_ID>.