Repository navigation
Conversation
e25938d to
aa40ff9
Compare
tmleman
changed the title
juimonen
left a comment
juimonen
left a comment
There was a problem hiding this comment.
not totally sure about the ipc flows, but looks ok to me.
aa40ff9 to
2ba3301
Compare
tmleman
changed the title
There was a problem hiding this comment.
Thanks for the detailed git commit message! I'm afraid you may need to udpate this now that we merged #7642 but that PR was older and had the approvals plus tests pass, so I merged that first.
There was a problem hiding this comment.
No problem, I think that it's better if we do zephyr update in smaller jumps.
There was a problem hiding this comment.
I'm too late to the review of the Zephyr side change, so I'm not going to block this here, but, but .... this does feel like a very common problem and problem that is typically solved without polling. I.e.
- get PM resource (prevent power gaing)
- send message
- wait for ack
- when ack received, release PM resource
But yeah, this kind of implements the same thing with a SOF side API, so this is probably good addition at this point.
Zepych update: total of 228 commits. Changes include: - build LNL with Zephyr SDK, - MMU initial implementation, - check for pending ack in intel_adsp_ipc_is_complete. Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>
The DSP cannot enter the power gating state if it has not yet received an ack from host after sending an ipc message. Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>
2ba3301 to
ab1fafc
Compare
|
Mandatory checks pass, known fails in https://sof-ci.01.org/sofpr/PR7623/build8445/devicetest/index.html and https://sof-ci.01.org/sofpr/PR7623/build8446/devicetest/index.html |
The DSP cannot enter the power gating state if it has not yet received an ack from host after sending an ipc message.