Repository navigation
topology2: enable multicore in nocodec topology for CI test - #7509
Merged
Merged
Conversation
RanderWang
changed the title
Collaborator
Author
|
|
mengdonglin
approved these changes
Apr 26, 2023
lgirdwood
approved these changes
Apr 26, 2023
plbossart
requested changes
Apr 28, 2023
plbossart
left a comment
plbossart
left a comment
Member
There was a problem hiding this comment.
I am not against the idea of having a simpler topology to start testing the multi-core parts, but please don't hard-code the core values. This needs to be defined with macros.
create another topology to test multicore since Currently we have done too much work in cavs-nocodec and CI test will be failed for main branch is not ready for multicore feature. Signed-off-by: Rander Wang <rander.wang@intel.com>
RanderWang
force-pushed
the
toplogy-multicore
branch
from
May 8, 2023 03:22
7620a45 to
919b115
Compare
Collaborator
Author
|
@plbossart use SSPX_CORE_ID to align with topology1. Thanks |
plbossart
approved these changes
May 8, 2023
| in_bit_depth 32 | ||
| in_valid_bit_depth 32 | ||
| out_bit_depth 32 | ||
| out_valid_bit_depth 32 |
Collaborator
There was a problem hiding this comment.
Yes to for clarity but its probably ok for now as it wont break anything
ranj063
approved these changes
May 10, 2023
ranj063
approved these changes
May 10, 2023
Collaborator
|
One PM fail in https://sof-ci.01.org/sofpr/PR7509/build7104/devicetest/index.html , not related to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create another topology to test multicore since Currently we have done too much work in cavs-nocodec and CI test will be failed for FW main branch is not ready for multicore feature.
Discussed with @mengdonglin that we need a separate topology to enable multicore feature to help this feature development in FW. This topology is not very complex since it is for test only