Repository navigation
Add support for SOF_IPC_FW_READY message initiated by host - #7463
Merged
Merged
Conversation
LaurentiuM1234
marked this pull request as ready for review
April 19, 2023 10:05
LaurentiuM1234
requested review from
abonislawski,
dbaluta,
iuliana-prodan,
kv2019i,
lbetlej,
lgirdwood,
lyakh,
mmaka1 and
plbossart
as code owners
April 19, 2023 10:05
paulstelian97
approved these changes
Apr 19, 2023
kv2019i
approved these changes
Apr 19, 2023
kv2019i
left a comment
kv2019i
left a comment
Collaborator
There was a problem hiding this comment.
I couldn't first make my mind whether this is an ABI change or not, but given this uses existing ABI definitions and is limited to one platform, my end conclusion is that this is not ABI change. Thanks for the good inline documentation, that helped in review.
iuliana-prodan
approved these changes
Apr 20, 2023
Collaborator
|
SOFCI TEST |
dbaluta
reviewed
Apr 24, 2023
Due to the fact that on i.MX93 the host will initialize the SOF_IPC_FW_READY sequence there's no need to call platform_boot_complete() at the end of start_complete(). This will be handled in the IPC3 handler. This commit makes sure that aforementioned scenario won't happen for i.MX93 while keeping the flow constant for the other platforms. Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
Contributor
Author
|
Fixed problems pointed out by @dbaluta. Please let me know if there's anything else you'd like me to address. Otherwise, IMO this is ready for merge. |
In the case of i.MX93 Linux will send an IPC_FW_READY message to SOF and will expect to receive the following information in the hostbox: 1) reply structure 2) sof_ipc_fw_ready structure 3) sof_ipc_fw_ready structure This flow is required because the FW (due to Jailhouse's design) will be up before the platform driver from Linux so the SOF_IPC_FW_READY sequence can't be initiated by SOF. Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
paulstelian97
approved these changes
Apr 28, 2023
dbaluta
approved these changes
Apr 28, 2023
Collaborator
|
thanks @LaurentiuM1234! will merge this once CI is ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case of i.MX93 Linux will send an IPC_FW_READY message to SOF and will expect to receive the following information in the hostbox:
1) reply structure
2) sof_ipc_fw_ready structure
3) sof_ipc_window structure
This flow is required because Jailhouse is currently controlled from user space. This means that SOF will be up before the platform driver from Linux so the IPC_FW_READY sequence can't be initiated by SOF.
Please see #7192 for PR dependency graph.