Repository navigation
zephyr: include: sof: Add Zephyr version of compiler_info.h - #7461
Merged
Merged
Conversation
LaurentiuM1234
marked this pull request as ready for review
April 19, 2023 10:03
LaurentiuM1234
requested review from
abonislawski,
dbaluta,
iuliana-prodan,
kv2019i and
lyakh
as code owners
April 19, 2023 10:03
paulstelian97
approved these changes
Apr 19, 2023
paulstelian97
left a comment
paulstelian97
left a comment
Collaborator
There was a problem hiding this comment.
Approve for now, this should be removed in the future whenever possible as it is a big hack in the end.
kv2019i
requested changes
Apr 19, 2023
kv2019i
left a comment
kv2019i
left a comment
Collaborator
There was a problem hiding this comment.
I don't think this is special to ARM64, this is SOF side abstraction that needs to be added for each new arch.
marc-hb
requested review from
aborisovich,
aiChaoSONG,
andyross,
dcpleung and
lgirdwood
April 20, 2023 21:28
This is required by ARM64 platforms as they don't have an arch/compiler_info.h so the compilation would fail. Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
Collaborator
|
Tests look ok. Filed an internal Intel ticket (#403) for the one FW file lookup check fail in https://sof-ci.01.org/sofpr/PR7461/build6235/devicetest/index.html Sparse is a known bug and fix is in progress. Likewise for Zephyr mainline build fails. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required by ARM64 platforms as they don't have an arch/compiler_info.h so the compilation would fail.
Please see #7192 for PR dependency graph.