Repository navigation
include: sof: debug: gdb: gdb.h: Add ifdef guard for symbol definition - #7460
Merged
Merged
Conversation
GDB debug should only be used when CONFIG_DBG_DEBUG=y. On ARM64 platforms with Zephyr, including this header will cause compilation errors due to the fact that they don't have an arch/ entry. This commit fixes this issue by conditionally defining all symbols based on CONFIG_GDB_DEBUG. Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
paulstelian97
approved these changes
Apr 19, 2023
kv2019i
approved these changes
Apr 19, 2023
iuliana-prodan
approved these changes
Apr 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GDB debug should only be used when CONFIG_DBG_DEBUG=y. On ARM64 platforms with Zephyr, including this header will cause compilation errors due to the fact that they don't have an arch/ entry. This commit fixes this issue by conditionally defining all symbols based on CONFIG_GDB_DEBUG.
Please see #7192 for PR dependency graph.