Repository navigation
audio: mixer: Fix inactive streams handling - #7420
Merged
Merged
Conversation
The previous patch 908876c introduced a bug where the wrong input buffer had the "consumed" field updated. This affected playing from _only_ the second input stream in weird ways (specifically, sound was slower and every other period I'd get a "no bytes to copy" message from the active host component). This patch fixes the indexing for that update. Fixes: 908876c "audio: mixer: Improve handling of inactive input streams" Signed-off-by: Paul Olaru <paul.olaru@nxp.com>
paulstelian97
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
April 7, 2023 09:49
dbaluta
approved these changes
Apr 7, 2023
iuliana-prodan
approved these changes
Apr 7, 2023
lyakh
approved these changes
Apr 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous patch 908876c introduced a bug where the wrong input buffer had the "consumed" field updated. This affected playing from only the second input stream in weird ways (specifically, sound was slower and every other period I'd get a "no bytes to copy" message from the active host component).
This patch fixes the indexing for that update.
Fixes: 908876c "audio: mixer: Improve handling of inactive input streams"