Repository navigation
[DNM]: drivers: imx: Move SAI MCLK enablement to sai_config() - #7410
Closed
LaurentiuM1234 wants to merge 1 commit into
Closed
LaurentiuM1234 wants to merge 1 commit into
LaurentiuM1234 wants to merge 1 commit into
Conversation
Due to the fact that MCLK signal comes after I2C's SCLK signal with an introlerable delay, the WM8962 codec seems to reach a bad state, leading to "DC servo timeout" issue on first playback. This was observed on i.MX93 and i.MX8MP with WM8962. This commit attempts to fix this by simply moving the MCLK enablement to sai_config(). Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
Contributor
Author
|
Made commit description and comment a bit more clearer. VERY IMPORTANT: this patch was only tested on i.MX93 with simple playback, simple capture and playback with PAUSE/RESUME. |
paulstelian97
approved these changes
Apr 6, 2023
paulstelian97
left a comment
paulstelian97
left a comment
Collaborator
There was a problem hiding this comment.
The change looks good. Once it's tested on 8MP with WM8962 as well I'd say it's good to merge.
LaurentiuM1234
changed the title
Contributor
Author
|
Marked as [DNM] until it can also be tested on 8MP. |
|
Can one of the admins verify this patch? |
lgirdwood
approved these changes
Apr 6, 2023
LaurentiuM1234
marked this pull request as draft
April 7, 2023 08:15
Contributor
Author
|
Marked this as a draft because it doesn't solve the issue on 8MP with WM8962. |
Contributor
Author
|
Will close this and let @iuliana-prodan handle it as this seems to be more problematic for 8MP with WM8962. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the fact that MCLK is enabled after I2C's SCLK signal, the WM8962 codec seems to reach a wrong state, leading to "DC servo timeout" issue on first playback. This was observed on i.MX93 and i.MX8MP with WM8962. This commit attempts to fix this by simply moving the MCLK enablement to sai_config().