Repository navigation
Conversation
Do not use intermediate macro SOC_DCACHE_FLUSH from Zephyr, use cache function instead. SOC_DCACHE_FLUSH will be removed from zephyr. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
nashif
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
March 28, 2023 21:08
kv2019i
requested changes
Mar 29, 2023
kv2019i
left a comment
kv2019i
left a comment
Collaborator
There was a problem hiding this comment.
One question on include guards, see inline.
| #include <ipc/topology.h> | ||
| #if defined(CONFIG_ARCH_XTENSA) && !defined(CONFIG_KERNEL_COHERENCE) | ||
| #include <zephyr/arch/xtensa/cache.h> | ||
| #endif |
Collaborator
There was a problem hiding this comment.
Hmm, if these are not defined, wouldn't the build anyways fail when z_xtensa_cache_flush() is not defined?
Contributor
Author
There was a problem hiding this comment.
do not remember why I did this, afaik this is the same in zephyr/lib/alloc.c
Member
There was a problem hiding this comment.
@kv2019i do we need to fix zephyr/lib/alloc.c or is this correct ?
|
Can one of the admins verify this patch? |
Collaborator
|
So this will no longer be needed, superseded by #7486 |
Collaborator
|
Code migrated to use sys_cache_, can close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not use intermediate macro SOC_DCACHE_FLUSH from Zephyr, use cache
function instead.
SOC_DCACHE_FLUSH will be removed from zephyr.
Signed-off-by: Anas Nashif anas.nashif@intel.com