Repository navigation
coherent: fix allocation size - #7323
Merged
Merged
Conversation
lyakh
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
March 22, 2023 11:32
kv2019i
reviewed
Mar 22, 2023
When adding object allocation to the coherent API the size alignment was misplaced, re-opening a possibility for cache corruption when sharing cache lines with adjacent allocations. Add alignment to all coherent object allocations. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
kv2019i
approved these changes
Mar 22, 2023
kv2019i
left a comment
kv2019i
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @lyakh !
@marcinszkudlinski , ok for you?
lgirdwood
approved these changes
Mar 22, 2023
marcinszkudlinski
approved these changes
Mar 22, 2023
softwarecki
approved these changes
Mar 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding object allocation to the coherent API the size alignment was misplaced, re-opening a possibility for cache corruption when sharing cache lines with adjacent allocations. Move alignment to the correct places.