Skip to content

cherry-pick: topology1: Align DAI format as SSP config to 24-bit for rt1019 - #7017

Merged
mwasko merged 1 commit into
thesofproject:rpl-001-drop-stablefrom
johnylin76:rpl-001-spk-core
Feb 3, 2023
Merged

cherry-pick: topology1: Align DAI format as SSP config to 24-bit for rt1019#7017
mwasko merged 1 commit into
thesofproject:rpl-001-drop-stablefrom
johnylin76:rpl-001-spk-core

Conversation

@johnylin76

@johnylin76 johnylin76 commented Feb 1, 2023

Copy link
Copy Markdown
Contributor

Cherry-picked from main

This commit fixes Speakers audio issue by aligning bitwidth format of DAI config to 24-bit as SSP config, which has been modified by
commit c8fe192 <topology1: change audio format to 24 bit for rt1019>

@johnylin76
topology1: Align DAI format as SSP config to 24-bit for rt1019
160e0f7 
This commit fixes Speakers audio issue by aligning bitwidth format
of DAI config to 24-bit as SSP config, which has been modified by
commit c8fe192 <topology1: change audio format to 24 bit for rt1019>

Signed-off-by: Pin-chih Lin <johnylin@google.com>
(cherry picked from commit 091948c)
lgirdwood
lgirdwood approved these changes Feb 1, 2023
View reviewed changes

@lgirdwood lgirdwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwasko topology cherry-pick, should this be for cavs25 branch ?

@johnylin76

johnylin76 commented Feb 2, 2023

Copy link
Copy Markdown
Contributor Author

@mwasko topology cherry-pick, should this be for cavs25 branch ?

IMO it should be. This commit is the fix for rt1019-codec topologies.

@mwasko

mwasko commented Feb 2, 2023

Copy link
Copy Markdown
Contributor

@mwasko topology cherry-pick, should this be for cavs25 branch ?

IMO it should be. This commit is the fix for rt1019-codec topologies.

I recommend to cherry-pick to cavs25 branch. We are currently only waiting for E2E validation results (delayed due to CNY) to officially announce cavs25.

@johnylin76

johnylin76 commented Feb 3, 2023

Copy link
Copy Markdown
Contributor Author

@mwasko topology cherry-pick, should this be for cavs25 branch ?

IMO it should be. This commit is the fix for rt1019-codec topologies.

I recommend to cherry-pick to cavs25 branch. We are currently only waiting for E2E validation results (delayed due to CNY) to officially announce cavs25.

cherry-picked and merged on cavs2.5 (#7031). Could this PR be merged now? @mwasko

@mwasko
mwasko merged commit 3c18423 into thesofproject:rpl-001-drop-stable Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgirdwood lgirdwood lgirdwood approved these changes
@kv2019i kv2019i kv2019i approved these changes
@cujomalainey cujomalainey Awaiting requested review from cujomalainey
@mwasko mwasko Awaiting requested review from mwasko
@Vamshigopal Vamshigopal Awaiting requested review from Vamshigopal
@marc-hb marc-hb Awaiting requested review from marc-hb
@aborisovich aborisovich Awaiting requested review from aborisovich

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@johnylin76 @mwasko @lgirdwood @kv2019i