Repository navigation
ipc4: dai: remove S32_LE hardcode for SSP DAIs - #6974
Merged
kv2019i merged 1 commit intoJan 23, 2023
Merged
Conversation
The limitation that SSP sample format is always S32_LE does not hold. There can be I2S codecs where 16bit sample width is used and SSP FIFO will expect 16bit samples from DMA. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
RanderWang,
abonislawski,
juimonen,
mmaka1 and
ranj063
January 19, 2023 21:12
kv2019i
requested review from
dbaluta,
lbetlej,
lgirdwood and
plbossart
as code owners
January 19, 2023 21:12
ranj063
approved these changes
Jan 19, 2023
juimonen
approved these changes
Jan 20, 2023
kv2019i
changed the title
Collaborator
Author
|
Tests seem good, but marking as DNM still for a while. Still a few unknowns w.r.t. format propagation I want to double-check before we proceed to merge this. |
lgirdwood
approved these changes
Jan 20, 2023
Member
kv2019i
changed the title
Collaborator
Author
|
Format propagation issue clearer and I see no reason to hold this PR anymore. |
Collaborator
Author
|
SOFCI TEST |
Collaborator
Author
|
#6864 hit once in https://sof-ci.01.org/sofpr/PR6974/build3485/devicetest/index.html?model=ADLP_RVP_SDW_IPC4ZPH&testcase=multiple-pause-resume-5 . Otherwise good, so proceeding with merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The limitation that SSP sample format is always S32_LE does not hold. There can be I2S codecs where 16bit sample width is used and SSP FIFO will expect 16bit samples from DMA.
Signed-off-by: Kai Vehmanen kai.vehmanen@linux.intel.com