Repository navigation
dai-zephyr: fix crash in dai_reset - #6972
Merged
Merged
Conversation
It is not guaranteed that 'dd->z_config' is set when dai_reset() is called. E.g. if the requested runtime parameters are not supported by the hardware, the parameter setup will not be completed. When dai_reset() is called in this state, a FW crash is hit due to NULL dereference. Fix the issue by checking dd->z_config value before use. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
January 19, 2023 16:20
ranj063
approved these changes
Jan 19, 2023
lyakh
approved these changes
Jan 20, 2023
dbaluta
approved these changes
Jan 20, 2023
Collaborator
|
This should be fine but it looks like there are some build failures. I guess github is troubled this days. |
Member
|
SOFCI TEST |
Member
|
Rerun the CI. |
abonislawski
approved these changes
Jan 20, 2023
Collaborator
Author
|
SOFCI TEST |
Collaborator
Author
|
Re-running CI once more. the DMA-CHAIN regression should be solved in upstream, so CI should now be clean for this PR. |
Collaborator
Author
|
One failure in https://sof-ci.01.org/sofpr/PR6972/build3478/devicetest/index.html caused by open issue #6864 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is not guaranteed that 'dd->z_config' is set when dai_reset() is called. E.g. if the requested runtime parameters are not supported by the hardware, the parameter setup will not be completed. When dai_reset() is called in this state, a FW crash is hit due to NULL dereference.
Fix the issue by checking dd->z_config value before use.
Signed-off-by: Kai Vehmanen kai.vehmanen@linux.intel.com