Skip to content

Revert "topology: hdmi-generic: change HDMI PCM id" - #6953

Closed
lgirdwood wants to merge 4 commits into
mainfrom
revert-6787-hdmi-cpm-id
Closed

lgirdwood wants to merge 4 commits into
mainfrom
revert-6787-hdmi-cpm-id

Conversation

@lgirdwood

Copy link
Copy Markdown
Member

Reverts #6787

@marc-hb

marc-hb commented Jan 13, 2023

Copy link
Copy Markdown
Collaborator

Should fix regression #6787

Devices unfortunately not available in https://sof-ci.01.org/sofpr/PR6953/build3368/devicetest/index.html, restarting hardware testing

@marc-hb

marc-hb commented Jan 13, 2023

Copy link
Copy Markdown
Collaborator

SOFCI TEST

@marc-hb

marc-hb commented Jan 13, 2023

Copy link
Copy Markdown
Collaborator

Lots of devices missing again in https://sof-ci.01.org/sofpr/PR6953/build3370/devicetest/index.html again, this is starting to look suspicious... @greg-intel , @fredoh9 ?

@marc-hb

marc-hb commented Jan 13, 2023

Copy link
Copy Markdown
Collaborator

SOFCI TEST

@greg-intel

greg-intel commented Jan 13, 2023 •

Copy link
Copy Markdown
Contributor

@marc-hb I saw three instances of "ERROR: Failed to retrieve Topology resource from..." (in the device testflows) for testplan 19889

@marc-hb

marc-hb commented Jan 13, 2023

Copy link
Copy Markdown
Collaborator

So https://sof-ci.01.org/sofpr/PR6953/build3371/devicetest/index.html is mostly empty again

As mentioned by Greg, job/testflow/61036 tries to download tplg/topology2/avs-tplg/sof-adl-rt711-4ch.tplg but it's NOT in the sof/PR6953-3370/build3370/tplg/topology2/avs-tplg/ folder in storage.

@marc-hb marc-hb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be on the safe side I fetched this and made sure it reverts #6787 exactly. So from that perspective: approved.

Obviously can't be merged as long as all tests are failing.

@marc-hb

marc-hb commented Jan 13, 2023 •

Copy link
Copy Markdown
Collaborator

I built both/after this revert and yes the revert does remove topology/topology2/avs-tplg/sof-adl-rt711-4ch.tplg (and others). So there's likely a "revert" required on the CI side too.

@kv2019i
kv2019i requested a review from bardliao January 16, 2023 08:42
@bardliao

bardliao commented Jan 16, 2023 •

Copy link
Copy Markdown
Collaborator

#6946 will fix #6947 and #6957 will fix the topology issue on ADL RVP. There is no need to revert #6787

@lgirdwood lgirdwood closed this Jan 18, 2023
@lgirdwood
lgirdwood deleted the revert-6787-hdmi-cpm-id branch January 18, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants