Skip to content

[DNM] xtensa-build-zephyr.py: pass extra parameters to signing tool - #6922

Closed
abonislawski wants to merge 1 commit into
thesofproject:stable-v2.4from
abonislawski:build_script_rimage_args
Closed

abonislawski wants to merge 1 commit into
thesofproject:stable-v2.4from
abonislawski:build_script_rimage_args

Conversation

@abonislawski

Copy link
Copy Markdown
Member

This will add scripts arguments -s --signing-tool-args to pass extra (optional) parameters to signing tool (rimage)

Example:

xtensa-build-zephyr.py -i IPC4 tgl -s="-v -i 3"

This will add scripts arguments -s --signing-tool-args to pass
extra (optional) parameters to rimage (west sign)

Example:

xtensa-build-zephyr.py -i IPC4 tgl -s="-v -i 3"

Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
@kv2019i

kv2019i commented Jan 9, 2023

Copy link
Copy Markdown
Collaborator

Ok with this on 2.4 branch as we need to sort out the appraoch with Zephyr zephyrproject-rtos/zephyr#52942 before we can commit this to SOF mainline.

marc-hb
marc-hb previously approved these changes Jan 9, 2023

@marc-hb marc-hb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for the 2.4 branch. For the main branch we need to converge on

and any other meu loose end.

@kv2019i kv2019i changed the title xtensa-build-zephyr.py: pass extra parameters to signing tool [DNM[ xtensa-build-zephyr.py: pass extra parameters to signing tool Jan 9, 2023
@kv2019i kv2019i changed the title [DNM[ xtensa-build-zephyr.py: pass extra parameters to signing tool [DNM] xtensa-build-zephyr.py: pass extra parameters to signing tool Jan 9, 2023
@kv2019i

kv2019i commented Jan 9, 2023

Copy link
Copy Markdown
Collaborator

Python issue picked up CI, @marc-hb looking into it... DNM until then.

@marc-hb

marc-hb commented Jan 9, 2023

Copy link
Copy Markdown
Collaborator

default=[] is already "split", that's why .split() fails in https://github.com/thesofproject/sof/actions/runs/3876401540/jobs/6610192118 and all others.

Splitting default="" yields non empty list [""] which would not work either.

Using shlex.split() in "competing" #6923, seems to work nicely.

@marc-hb

marc-hb commented Jan 10, 2023

Copy link
Copy Markdown
Collaborator

#6923 merged

@marc-hb marc-hb closed this Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants