Skip to content

topology2: add auxiliary data classes for ssp - #6860

Merged
lgirdwood merged 1 commit into
thesofproject:mainfrom
juimonen:ssp_aux_data
Dec 22, 2022
Merged

lgirdwood merged 1 commit into
thesofproject:mainfrom
juimonen:ssp_aux_data

Conversation

@juimonen

Copy link
Copy Markdown

Auxiliary data can be added at the end of ssp data blob to enable for example early clocks for certain platform. Add aux_config.conf that includes all possible aux data classes. These can be used inside hw_configs and will be embedded as tlv data after basic data blob.

Signed-off-by: Jaska Uimonen jaska.uimonen@intel.com

@lgirdwood lgirdwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of this look generic whilst some is obviously Intel specific - can this be split ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fixed now

@juimonen

Copy link
Copy Markdown
Author

A lot of this look generic whilst some is obviously Intel specific - can this be split ?

so this is very very intel specific... I think we did some of the stuff with ipc3 already, so I think some items are overlapping with old sof parameters. I don't know should this be moved to some intel directory then?

@juimonen
juimonen requested a review from ranj063 December 20, 2022 16:34
Auxiliary data can be added at the end of ssp data blob to enable for
example early clocks for certain platform. Add intel_ssp_aux_config.conf
that includes all possible aux data classes. These can be used inside
ssp hw_configs and will be embedded as tlv data after basic data blob.

Example of using mn_config class inside hw_config:

Object.Base.hw_config."SSP0_0" {
	id              0
	mclk_freq       38400000
	bclk_freq       256000
	tdm_slot_width  16
	format          "DSP_A"
	bclk            "codec_provider"
	fsync           "codec_provider"
	fsync_freq      16000

	Object.Base.mn_config."MN_0" {
		m_div   100
		n_div   200
	}
}

Signed-off-by: Jaska Uimonen <jaska.uimonen@intel.com>
@lgirdwood

Copy link
Copy Markdown
Member

A lot of this look generic whilst some is obviously Intel specific - can this be split ?

so this is very very intel specific... I think we did some of the stuff with ipc3 already, so I think some items are overlapping with old sof parameters. I don't know should this be moved to some intel directory then?

yes and lets call the file intel_something

@juimonen

Copy link
Copy Markdown
Author

@lgirdwood so classes are now in include/dais/intel/intel_ssp_aux_data.conf
we had a intel dir in platform, but new class definitions didn't really seem to fit there (at least from my point of view).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants