Skip to content

selector: remove return error when input buffer is 0 - #6827

Merged
kv2019i merged 1 commit into
thesofproject:mainfrom
fkwasowi:prv-fkwasowi_issue_6793
Dec 19, 2022
Merged

kv2019i merged 1 commit into
thesofproject:mainfrom
fkwasowi:prv-fkwasowi_issue_6793

Conversation

@fkwasowi

Copy link
Copy Markdown
Contributor

A pipeline that contains a selector cannot be run before the pipeline that is connected to the selector because an error is returned. The order of the run pipelines should not matter for functionality.

@ranj063

ranj063 commented Dec 16, 2022

Copy link
Copy Markdown
Collaborator

@fkwasowi does this fix a known issue?

@fkwasowi

Copy link
Copy Markdown
Contributor Author

@fkwasowi does this fix a known issue?

Yes, that's the fix for this issue: #6793

@fkwasowi

Copy link
Copy Markdown
Contributor Author

SOFCI TEST

@kv2019i kv2019i left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fkwasowi , looks good!

@RanderWang Can you maybe look at this. The PPL_STATUS_PATH_STOP branch was added in your original IPC4 selector support patch.

Comment thread src/audio/selector/selector.c Outdated
A pipeline that contains a selector cannot be run before the pipeline
that is connected to the selector because an error is returned.
The order of the run pipelines should not matter for functionality.

Signed-off-by: Kwasowiec, Fabiola <fabiola.kwasowiec@intel.com>
@fkwasowi
fkwasowi force-pushed the prv-fkwasowi_issue_6793 branch from e3186bc to d53f9ce Compare December 19, 2022 09:48
@fkwasowi fkwasowi changed the title selector: remove return error when ipunt buffer is 0 selector: remove return error when input buffer is 0 Dec 19, 2022
@fkwasowi
fkwasowi requested a review from libinyang December 19, 2022 09:54
@fkwasowi

Copy link
Copy Markdown
Contributor Author

SOFCI TEST

@ranj063

ranj063 commented Dec 19, 2022

Copy link
Copy Markdown
Collaborator

SOFCI TEST

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants